-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: update AWS Bedrock cross-region inference profile mapping, Closed issue #2704 #4973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update AWS Bedrock cross-region inference profile mapping, Closed issue #2704 #4973
Conversation
- Add AWS_INFERENCE_PROFILE_MAPPING with official inference profile prefixes - Update getPrefixForRegion to use AWS recommended inference profiles - Improve region-to-profile mapping based on AWS documentation - Prioritize more specific region patterns (e.g., us-gov- before us-) - Add support for apac., ca., sa., and ug. inference profiles
daniel-lxs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @KevinZhao, thank you for your PR!
This looks like a solid implementation, I left some suggestions to hopefully get this ready and merged.
Let me know what you think!
|
Yes, I checked BEDROCK_REGION_INFO, this should be incorrect from previous version, hence I removed it and testing in my local enviroment, will update by EOD. |
- Add AWS_INFERENCE_PROFILE_MAPPING with priority-based region selection - Update BEDROCK_REGIONS constant for UI components - Enhance getPrefixForRegion function for cross-region inference - Add comprehensive test coverage for new inference profiles system - Support 24 AWS regions including government cloud regions Fixes: AWS Bedrock region mapping and cross-region inference functionality
|
I removed logic of BEDROCK_REGION_INFO, as it mislead the model id configuration, and I instead create a simple BEDROCK_REGIONS for UI to display regions. I also adding test cases for current implementations. |
daniel-lxs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @KevinZhao for your contribution!
LGTM
Related GitHub Issue
Closes: # <2704>
#2704
Description
Test Procedure
Type of Change
srcor test files.Pre-Submission Checklist
npm run lint).console.log) has been removed.npm test).mainbranch.npm run changesetif this PR includes user-facing changes or dependency updates.Screenshots / Videos
Documentation Updates
Additional Notes
Get in Touch
Important
Updates AWS Bedrock cross-region inference profile mapping to use AWS's recommended inference profiles, addressing issue #2704.
getPrefixForRegion()inbedrock.tsto use AWS recommended inference profiles for cross-region inference.AWS_INFERENCE_PROFILE_MAPPINGinbedrock.tsfor mapping regions to inference profiles.AwsBedrockHandlerinbedrock.tsto apply cross-region inference prefixes usingAWS_INFERENCE_PROFILE_MAPPING.This description was created by
for 5be82b9. You can customize this summary. It will automatically update as commits are pushed.