Skip to content

Conversation

@daniel-lxs
Copy link
Member

@daniel-lxs daniel-lxs commented Jun 22, 2025

Summary

This PR refines the PR Reviewer mode to be more focused and concise in its review approach.

Changes

  • Remove all praise and positive comments from reviews - focus exclusively on issues that need attention
  • Avoid markdown headings entirely in review comments (###, ##, #)
  • Use markdown sparingly - only for code blocks or when absolutely necessary for clarity
  • Maintain friendly, curious tone while asking about potential intentions behind code choices
  • Focus on actionable feedback rather than unnecessary formatting

Files Modified

    • Updated review comment guidelines
    • Added explicit best practices about focusing on issues and minimal markdown
    • Added specific mistakes to avoid regarding praise and markdown usage

Impact

The PR Reviewer mode will now provide more direct, issue-focused feedback while maintaining a constructive tone. This should result in cleaner, more actionable review comments without unnecessary formatting or praise.


Important

Refines PR Reviewer mode to focus on issues, minimize markdown, and remove praise in review comments.

  • Behavior:
    • Removes all praise and positive comments from reviews, focusing exclusively on issues.
    • Avoids markdown headings entirely in review comments.
    • Uses markdown sparingly, only for code blocks or when necessary for clarity.
    • Maintains a friendly, curious tone while asking about code choices.
    • Focuses on actionable feedback rather than unnecessary formatting.
  • Files Modified:
    • Updates 1_workflow.xml to refine review comment guidelines.
    • Updates 2_best_practices.xml to emphasize issue focus and minimal markdown.
    • Updates 3_common_mistakes_to_avoid.xml to specify mistakes regarding praise and markdown usage.
  • Impact:
    • Provides more direct, issue-focused feedback with a constructive tone, resulting in cleaner review comments.

This description was created by Ellipsis for 045d5f8. You can customize this summary. It will automatically update as commits are pushed.

- Remove all praise and positive comments from reviews
- Avoid markdown headings entirely in review comments
- Use markdown sparingly, only for code blocks or essential clarity
- Maintain friendly, curious tone while asking about potential intentions
- Focus exclusively on issues that need attention
@daniel-lxs daniel-lxs requested review from cte, jr and mrubens as code owners June 22, 2025 18:05
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Jun 22, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Jun 22, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 23, 2025
@mrubens mrubens merged commit 35cdcf4 into main Jun 23, 2025
22 checks passed
@mrubens mrubens deleted the refine-pr-reviewer-mode branch June 23, 2025 02:53
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jun 23, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 23, 2025
Alorse pushed a commit to Alorse/Roo-Code that referenced this pull request Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer PR - Needs Review size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants