Skip to content

Fix openai handle azure more correctly fix #430 #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
samhvw8 wants to merge 1 commit into from
Closed

Fix openai handle azure more correctly fix #430 #505

samhvw8 wants to merge 1 commit into from

Conversation

@samhvw8
Copy link
Contributor

@samhvw8 samhvw8 commented Jan 23, 2025 •
edited by ellipsis-dev bot
Loading

close #430

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the patterns of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Additional context

Related Issues

Reviewers

Important

Fixes Azure URL detection in OpenAiHandler constructor by checking if openAiBaseUrl includes "azure.com".

This description was created by Ellipsis for 965f106. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2025

⚠️ No Changeset found

Latest commit: 965f106

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@samhvw8 samhvw8 mentioned this pull request Jan 23, 2025
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 23, 2025
View reviewed changes
src/api/providers/openai.ts
// Azure API shape slightly differs from the core API shape: https://github.com/openai/openai-node?tab=readme-ov-file#microsoft-azure-openai
const urlHost = new URL(this.options.openAiBaseUrl ?? "").host
if (urlHost === "azure.com" || urlHost.endsWith(".azure.com")) {
if (this.options.openAiBaseUrl?.toLowerCase().includes("azure.com")) {

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization High

'
azure.com
Loading
' can be anywhere in the URL, and arbitrary hosts may come before or after it.
Copy link
Collaborator

@mrubens mrubens Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind fixing this?

Copy link
Contributor Author

@samhvw8 samhvw8 Jan 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is from cline upstream, i think it will be ok, to handle case "https://[recourncename].openai.azure.com/openai" where azure is in middle or baseUrl

@samhvw8 samhvw8 closed this Jan 23, 2025
@samhvw8 samhvw8 deleted the fix/azure-openai-bug-baseurl-handling branch January 24, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stea9499 stea9499 Awaiting requested review from stea9499

@ColemanRoo ColemanRoo Awaiting requested review from ColemanRoo

@mrubens mrubens Awaiting requested review from mrubens mrubens is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Azure OpenAI Bug for not handling baseURL properly.

2 participants

@samhvw8 @mrubens