Skip to content

Fix openai handle azure more correctly fix #430 #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
samhvw8 wants to merge 1 commit into from
Closed

Fix openai handle azure more correctly fix #430 #505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/api/providers/openai.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@
constructor(options: ApiHandlerOptions) {
this.options = options
// Azure API shape slightly differs from the core API shape: https://github.com/openai/openai-node?tab=readme-ov-file#microsoft-azure-openai
const urlHost = new URL(this.options.openAiBaseUrl ?? "").host
if (urlHost === "azure.com" || urlHost.endsWith(".azure.com")) {
if (this.options.openAiBaseUrl?.toLowerCase().includes("azure.com")) {

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization High

'
azure.com
Loading
' can be anywhere in the URL, and arbitrary hosts may come before or after it.
Copy link
Collaborator

@mrubens mrubens Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind fixing this?

Copy link
Contributor Author

@samhvw8 samhvw8 Jan 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is from cline upstream, i think it will be ok, to handle case "https://[recourncename].openai.azure.com/openai" where azure is in middle or baseUrl

this.client = new AzureOpenAI({
baseURL: this.options.openAiBaseUrl,
apiKey: this.options.openAiApiKey,
Expand Down
Loading