Fix #5294: Prevent Architect mode from providing time estimates #5295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
|
✅ No security or compliance issues detected. Reviewed everything up to 94416e6. Security Overview
Detected Code Changes
Reply to this PR with |
hannesrudolph
added
the
Issue/PR - Triage
- Updated Architect mode custom instructions to explicitly prohibit providing time estimates - Added clear guidance to focus on actionable plans without speculating about implementation timeframes - Updated test snapshot to reflect the new instruction - All tests passing
jr
approved these changes
Jul 1, 2025
Collaborator
jr
left a comment
jr
left a comment
There was a problem hiding this comment.
In some light testing this does seem to cut down on the markdown a lot / make it a lot more likely that the first suggestion at the "end" is switching to code mode and implementing.
I did still sometimes get a roadmap, but it at least seemed less specific about times.
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
daniel-lxs
approved these changes
Jul 1, 2025
| description: "Plan and design before implementation", | ||
| groups: ["read", ["edit", { fileRegex: "\\.md$", description: "Markdown files only" }], "browser", "mcp"], | ||
| customInstructions: | ||
| "1. Do some information gathering (for example using read_file or search_files) to get more context about the task.\n\n2. You should also ask the user clarifying questions to get a better understanding of the task.\n\n3. Once you've gained more context about the user's request, you should create a detailed plan for how to accomplish the task. Include Mermaid diagrams if they help make your plan clearer.\n\n4. Ask the user if they are pleased with this plan, or if they would like to make any changes. Think of this as a brainstorming session where you can discuss the task and plan the best way to accomplish it.\n\n5. Once the user confirms the plan, ask them if they'd like you to write it to a markdown file.\n\n6. Use the switch_mode tool to request that the user switch to another mode to implement the solution.", |
Member
There was a problem hiding this comment.
I noticed that step 5 about creating a Markdown file was removed, which doesn't appear to have been mentioned in the original issue.
If this change is desirable, then I don't see any issues with this PR.
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Needs Review]
in Roo Code Roadmap
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
hannesrudolph
pushed a commit
that referenced
this pull request
Jul 3, 2025
* Fixes #5294: Add instruction to Architect mode to avoid time estimates - Updated Architect mode custom instructions to explicitly prohibit providing time estimates - Added clear guidance to focus on actionable plans without speculating about implementation timeframes - Updated test snapshot to reflect the new instruction - All tests passing * More tweaks to prompt --------- Co-authored-by: Matt Rubens <[email protected]>
utarn
pushed a commit
to modelharbor/ModelHarbor-Agent
that referenced
this pull request
Jul 4, 2025
…ates (RooCodeInc#5295) * Fixes RooCodeInc#5294: Add instruction to Architect mode to avoid time estimates - Updated Architect mode custom instructions to explicitly prohibit providing time estimates - Added clear guidance to focus on actionable plans without speculating about implementation timeframes - Updated test snapshot to reflect the new instruction - All tests passing * More tweaks to prompt --------- Co-authored-by: Matt Rubens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5294 by updating the Architect mode's custom instructions to explicitly prohibit providing time estimates for task completion.
Problem
The Architect mode was creating plans with unrealistic time estimates (days/weeks) that didn't match the actual implementation time (minutes). This created confusion and set incorrect expectations.
Solution
Added a clear instruction to the Architect mode's customInstructions in src/shared/modes.ts:
IMPORTANT: Do not provide time estimates for how long tasks will take to complete. Focus on creating clear, actionable plans without speculating about implementation timeframes.
Changes
Testing
The Architect mode will now focus on creating clear, actionable plans without providing potentially misleading time estimates.
Important
Updates Architect mode in
modes.tsto prohibit time estimates, focusing on actionable plans, with updated test snapshots.customInstructionsinmodes.tsto prohibit time estimates, focusing on actionable plans.add-custom-instructions/architect-mode-prompt.snapand 9 other files to reflect new instructions.This description was created by
for 94416e6. You can customize this summary. It will automatically update as commits are pushed.