-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: Add General settings for all-workspace tasks and Bangla localization #5338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| } | ||
|
|
||
| export const GeneralSettings = ({ showAllWorkspacesTasks, setCachedStateField }: GeneralProps) => { | ||
| const handleShowAllTasks = (e: any) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The handleShowAllTasks function uses an 'any' event type. Use React.ChangeEvent for better type safety.
| const handleShowAllTasks = (e: any) => { | |
| const handleShowAllTasks = (e: React.ChangeEvent<HTMLInputElement>) => { |
|
Hey @omagoduck, thank you for your contribution! I think it would be a good idea to split this PR into two separate ones: one for the localization changes and another for the workspace-related updates. That way, it’ll be easier to review and test the actual code changes in isolation. Let me know what you think! |
|
But @daniel-lxs the workspace update contain some localization update which is also included for new added Bangla language. Please consider it. |
locales/bn/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typographical inconsistency: The mode is referred to as “নিজস্ব মোড” in line 45 but appears as “নিজশ্ব মোড” in line 88. Please standardize the spelling (preferably as “নিজস্ব মোড”).
| - **[নিজশ্ব মোড](https://docs.roocode.com/advanced-usage/custom-modes):** নিরাপত্তা অডিট, কর্মক্ষমতা অপ্টিমাইজেশন, ডকুমেন্টেশন বা অন্য যেকোনো কাজের জন্য অসীম সংখ্যক বিশেষায়িত চরিত্র তৈরি করুন | |
| - **[নিজস্ব মোড](https://docs.roocode.com/advanced-usage/custom-modes):** নিরাপত্তা অডিট, কর্মক্ষমতা অপ্টিমাইজেশন, ডকুমেন্টেশন বা অন্য যেকোনো কাজের জন্য অসীম সংখ্যক বিশেষায়িত চরিত্র তৈরি করুন |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo detected: The string ".rooignore'd" on this line appears to include an unintended English contraction. Consider revising it to a more appropriate Bangla phrasing (e.g. ".rooignore-এর") to maintain consistency in the localization.
| "label": "তালিকা এবং অনুসন্ধানে .rooignore'd ফাইলগুলি দেখান", | |
| "label": "তালিকা এবং অনুসন্ধানে .rooignore-এর ফাইলগুলি দেখান", |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lexicographical inconsistency: The term 'Roo' is used here while the rest of the file refers to 'রু কোড'. Consider using a consistent naming convention.
| "chooseProvider": "এর জাদু প্রদর্শনের জন্য, Roo-এর একটি API চাবি প্রয়োজন।", | |
| "chooseProvider": "এর জাদু প্রদর্শনের জন্য, রু কোড-এর একটি API চাবি প্রয়োজন।", |
This comment was generated because it violated a code review rule: irule_VrRKWqywZ2YV2SOE.
|
i am a newcomer. You could just add my updates to the main repo, I am a new deveeloper and is hassling to keep pace with you rapidly updating codebase. what the procedure is |
…lowed git bot's type safety suggetion.
|
Can anyone say why it is not on track? |
|
Hey @omagoduck, thanks for your contribution! I really appreciate the effort you've put into both the settings feature and the Bangla localization. I understand keeping up with a rapidly changing codebase can be frustrating, especially as a newcomer - I've been there too! The reason we're asking to split this PR is that with 107 files changed, it's really hard to give each part the proper review it deserves. Quick suggestion: Could you create two separate PRs?
This way:
I know it feels like extra work, but it actually makes the process smoother for everyone. We want to get your contributions merged - splitting them just helps us do that more effectively! If you need any help with git commands or the process, just ask. We're here to help! 🙂 |
|
@daniel-lxs I am again repeating. My Bangla update have also keys for the settings update. If I have to split PR then I have to do the Bangla update without settings update cause, they are not gonna approved faster right? Still if you want, I can split. Thanks for co-operation. |
|
Yes, ideally create two separate branches and PRs:
This makes reviews faster and avoids blocking. Hit me up if you have any questions. |
|
@daniel-lxs I splited and moved the settings update PR already to the new PR #5415 |
|
This is not something we believe is going to increase the QOL for many users. We are working towards splitting workspace history in a way that will likely break this if it was implemented. Please create an issue to add the Bengali language so we can approve it and then you could make a PR for that. Thank you. |
Related GitHub Issue
Closes: #5336
Roo Code Task Context (Optional)
Description
Test Procedure
Pre-Submission Checklist
Screenshots / Videos
Documentation Updates
Additional Notes
Get in Touch
Important
Adds a setting to view tasks from all workspaces and introduces Bangla localization.
showAllWorkspacesTasksto view tasks from all workspaces inwebviewMessageHandler.ts.HistoryView.tsxto include a toggle forshowAllWorkspacesTasks.useTaskSearch.tsto filter tasks based onshowAllWorkspacesTasks.locales/bn/CODE_OF_CONDUCT.md,locales/bn/CONTRIBUTING.md, andlocales/bn/README.md.GeneralSettings.tsxto manageshowAllWorkspacesTaskssetting.SettingsView.tsxto include the new general settings section.This description was created by
for e6796b7945eb989ff2e87074902d5efcee01d5dd. You can customize this summary. It will automatically update as commits are pushed.