Skip to content

Conversation

@omagoduck
Copy link

@omagoduck omagoduck commented Jul 2, 2025

Related GitHub Issue

Closes: #5336

Roo Code Task Context (Optional)

Description

Test Procedure

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch


Important

Adds a setting to view tasks from all workspaces and introduces Bangla localization.

  • Behavior:
    • Adds a new setting showAllWorkspacesTasks to view tasks from all workspaces in webviewMessageHandler.ts.
    • Updates HistoryView.tsx to include a toggle for showAllWorkspacesTasks.
    • Modifies useTaskSearch.ts to filter tasks based on showAllWorkspacesTasks.
  • Localization:
    • Adds Bangla translations in locales/bn/CODE_OF_CONDUCT.md, locales/bn/CONTRIBUTING.md, and locales/bn/README.md.
  • Settings:
    • Introduces GeneralSettings.tsx to manage showAllWorkspacesTasks setting.
    • Updates SettingsView.tsx to include the new general settings section.

This description was created by Ellipsis for e6796b7945eb989ff2e87074902d5efcee01d5dd. You can customize this summary. It will automatically update as commits are pushed.

@omagoduck omagoduck requested review from cte, jr and mrubens as code owners July 2, 2025 13:08
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Jul 2, 2025
}

export const GeneralSettings = ({ showAllWorkspacesTasks, setCachedStateField }: GeneralProps) => {
const handleShowAllTasks = (e: any) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The handleShowAllTasks function uses an 'any' event type. Use React.ChangeEvent for better type safety.

Suggested change
const handleShowAllTasks = (e: any) => {
const handleShowAllTasks = (e: React.ChangeEvent<HTMLInputElement>) => {

@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jul 2, 2025
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jul 2, 2025
@daniel-lxs
Copy link
Member

Hey @omagoduck, thank you for your contribution!

I think it would be a good idea to split this PR into two separate ones: one for the localization changes and another for the workspace-related updates. That way, it’ll be easier to review and test the actual code changes in isolation.

Let me know what you think!

@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Draft / In Progress] in Roo Code Roadmap Jul 2, 2025
@daniel-lxs daniel-lxs marked this pull request as draft July 2, 2025 22:52
@omagoduck
Copy link
Author

But @daniel-lxs the workspace update contain some localization update which is also included for new added Bangla language. Please consider it.

@omagoduck omagoduck marked this pull request as ready for review July 3, 2025 05:04
@dosubot dosubot bot added documentation Improvements or additions to documentation UI/UX UI/UX related or focused labels Jul 3, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typographical inconsistency: The mode is referred to as “নিজস্ব মোড” in line 45 but appears as “নিজশ্ব মোড” in line 88. Please standardize the spelling (preferably as “নিজস্ব মোড”).

Suggested change
- **[নিজশ্ব মোড](https://docs.roocode.com/advanced-usage/custom-modes):** নিরাপত্তা অডিট, কর্মক্ষমতা অপ্টিমাইজেশন, ডকুমেন্টেশন বা অন্য যেকোনো কাজের জন্য অসীম সংখ্যক বিশেষায়িত চরিত্র তৈরি করুন
- **[নিজস্ব মোড](https://docs.roocode.com/advanced-usage/custom-modes):** নিরাপত্তা অডিট, কর্মক্ষমতা অপ্টিমাইজেশন, ডকুমেন্টেশন বা অন্য যেকোনো কাজের জন্য অসীম সংখ্যক বিশেষায়িত চরিত্র তৈরি করুন

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo detected: The string ".rooignore'd" on this line appears to include an unintended English contraction. Consider revising it to a more appropriate Bangla phrasing (e.g. ".rooignore-এর") to maintain consistency in the localization.

Suggested change
"label": "তালিকা এবং অনুসন্ধানে .rooignore'd ফাইলগুলি দেখান",
"label": "তালিকা এবং অনুসন্ধানে .rooignore-এর ফাইলগুলি দেখান",

This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lexicographical inconsistency: The term 'Roo' is used here while the rest of the file refers to 'রু কোড'. Consider using a consistent naming convention.

Suggested change
"chooseProvider": "এর জাদু প্রদর্শনের জন্য, Roo-এর একটি API চাবি প্রয়োজন।",
"chooseProvider": "এর জাদু প্রদর্শনের জন্য, রু কোড-এর একটি API চাবি প্রয়োজন।",

This comment was generated because it violated a code review rule: irule_VrRKWqywZ2YV2SOE.

@omagoduck
Copy link
Author

omagoduck commented Jul 3, 2025

i am a newcomer. You could just add my updates to the main repo, I am a new deveeloper and is hassling to keep pace with you rapidly updating codebase. what the procedure is
@daniel-lxs @mrubens @hannesrudolph @jr

@omagoduck
Copy link
Author

Can anyone say why it is not on track?

@daniel-lxs
Copy link
Member

Hey @omagoduck, thanks for your contribution! I really appreciate the effort you've put into both the settings feature and the Bangla localization.

I understand keeping up with a rapidly changing codebase can be frustrating, especially as a newcomer - I've been there too! The reason we're asking to split this PR is that with 107 files changed, it's really hard to give each part the proper review it deserves.

Quick suggestion: Could you create two separate PRs?

  • One for the settings feature (just the ~5 files for showAllWorkspacesTasks)
  • One for the Bangla translations

This way:

  • Each PR gets reviewed faster
  • If one needs changes, it won't block the other
  • It's easier for us to help you get your code merged

I know it feels like extra work, but it actually makes the process smoother for everyone. We want to get your contributions merged - splitting them just helps us do that more effectively!

If you need any help with git commands or the process, just ask. We're here to help! 🙂

@omagoduck
Copy link
Author

omagoduck commented Jul 4, 2025

@daniel-lxs
I can do that. But splitting into two PR? So two seperate PR with two seperate branch? Or two new PR with current branch?

I am again repeating. My Bangla update have also keys for the settings update. If I have to split PR then I have to do the Bangla update without settings update cause, they are not gonna approved faster right?

Still if you want, I can split. Thanks for co-operation.

@daniel-lxs
Copy link
Member

Yes, ideally create two separate branches and PRs:

  1. Settings Feature PR

    • Include only the changes for showAllWorkspacesTasks (about 5 files).
  2. Bangla Translations PR

    • Include all other general translation updates.

This makes reviews faster and avoids blocking. Hit me up if you have any questions.

@omagoduck
Copy link
Author

@daniel-lxs I splited and moved the settings update PR already to the new PR #5415

@hannesrudolph
Copy link
Collaborator

This is not something we believe is going to increase the QOL for many users. We are working towards splitting workspace history in a way that will likely break this if it was implemented.

Please create an issue to add the Bengali language so we can approve it and then you could make a PR for that. Thank you.

@github-project-automation github-project-automation bot moved this from PR [Draft / In Progress] to Done in Roo Code Roadmap Jul 7, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request PR - Draft / In Progress size:XXL This PR changes 1000+ lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Enable me to see all workspaces from recent tasks UI based on my preference.

3 participants