fix: reset user response flag on new ask messages to fix auto-approval #5508
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where subsequent tool calls would not be auto-approved after the
update_todo_listtool was used, even when auto-approval was enabled.Problem
After the
update_todo_listtool execution, theuserRespondedRef.currentflag remainedtrue, causing the auto-approval logic to exit early for all subsequent tool requests. This meant that even though auto-approval was enabled for various tools, they would still require manual approval.Solution
The fix resets the
userRespondedRef.currentflag tofalsewhenever a new ask message arrives. This ensures that each tool request is evaluated for auto-approval independently, without being affected by previous user interactions or auto-approvals.Changes Made
userRespondedRef.current = falseat the beginning of the ask message processing in theuseDeepCompareEffecthookTesting
The user has confirmed that this fix resolves the issue and auto-approval now works correctly for subsequent tools after
update_todo_listis used.Checklist
Important
Fixes auto-approval issue in
ChatView.tsxby resettinguserRespondedRef.currenton new "ask" messages.userRespondedRef.currenttofalseon new "ask" messages inChatViewComponent.userRespondedRef.current = falseinuseDeepCompareEffecthook inChatView.tsx.This description was created by
for 51beb55. You can customize this summary. It will automatically update as commits are pushed.