Skip to content

Conversation

@shubhamgupta731
Copy link
Contributor

@shubhamgupta731 shubhamgupta731 commented Jul 10, 2025

Related GitHub Issue

Closes: #5555

Description

This PR updates the Vertex AI provider configuration to include all currently supported regions in the VERTEX_REGIONS array, as defined in packages/types/src/providers/vertex.ts. This ensures users can select any available region for model deployment and compliance, including but not limited to asia-east1, us-central1, europe-west1, and others.

Key implementation details:

  • The region dropdown in the Vertex AI provider settings now reflects the complete set of supported regions.
  • The region list is sourced from a single configuration array to avoid hardcoding and ensure maintainability.
  • All code follows existing region handling patterns.

Test Procedure

  • Verified all regions appear in the region dropdown in the Vertex AI provider settings.
  • Ran all tests in Vertex.spec.tsx and confirmed they pass.
  • Checked for lint and style compliance.

Reviewers can reproduce these tests by:

  1. Opening the Vertex AI provider settings and confirming all regions are present in the dropdown.
  2. Running Vertex.spec.tsx and verifying all tests pass.
  3. Running lint and style checks to confirm compliance.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Before After

Documentation Updates

  • No documentation updates are required.

Additional Notes

Get in Touch

shubhamgupta731


Important

Adds asia-east1 to VERTEX_REGIONS and introduces tests to ensure correct region handling in Vertex AI.

  • Behavior:
    • Adds asia-east1 to VERTEX_REGIONS in vertex.ts to expand supported regions.
    • Ensures all regions are selectable in the Vertex AI provider settings.
  • Testing:
    • New test file Vertex.spec.tsx verifies VERTEX_REGIONS includes 'global' and 'asia-east1' exactly once.
    • Confirms all expected regions are present in VERTEX_REGIONS.

This description was created by Ellipsis for f855fdf. You can customize this summary. It will automatically update as commits are pushed.

Shubham Gupta added 2 commits July 10, 2025 14:44
… models (e.g., Anthropic Claude) and ensure compliance with GCP region-level restrictions, enabling flexible model deployment.
… models (e.g., Anthropic Claude) and ensure compliance with GCP region-level restrictions, enabling flexible model deployment.
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Jul 10, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 10, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jul 10, 2025
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jul 10, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 10, 2025
Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @shubhamgupta731!

@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Needs Review] in Roo Code Roadmap Jul 10, 2025
@mrubens mrubens merged commit 4771864 into RooCodeInc:main Jul 10, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jul 10, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer PR - Needs Preliminary Review size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Archived in project

4 participants