Skip to content

Expand Vertex AI region config to include all available regions in GCP Vertex AI #5557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2025
Merged

Expand Vertex AI region config to include all available regions in GCP Vertex AI #5557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca838cc
Include all Vertex AI regions in configuration to support third-party…
Jul 10, 2025
f855fdf
Include all Vertex AI regions in configuration to support third-party…
Jul 10, 2025
81a3f9f
fix: add all expected Vertex AI regions to VERTEX_REGIONS constant
daniel-lxs Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion packages/types/src/providers/vertex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,9 +277,35 @@ export const vertexModels = {

export const VERTEX_REGIONS = [
{ value: "global", label: "global" },
{ value: "us-east5", label: "us-east5" },
{ value: "us-central1", label: "us-central1" },
{ value: "us-east1", label: "us-east1" },
{ value: "us-east4", label: "us-east4" },
{ value: "us-east5", label: "us-east5" },
{ value: "us-west1", label: "us-west1" },
{ value: "us-west2", label: "us-west2" },
{ value: "us-west3", label: "us-west3" },
{ value: "us-west4", label: "us-west4" },
{ value: "northamerica-northeast1", label: "northamerica-northeast1" },
{ value: "northamerica-northeast2", label: "northamerica-northeast2" },
{ value: "southamerica-east1", label: "southamerica-east1" },
{ value: "europe-west1", label: "europe-west1" },
{ value: "europe-west2", label: "europe-west2" },
{ value: "europe-west3", label: "europe-west3" },
{ value: "europe-west4", label: "europe-west4" },
{ value: "europe-west6", label: "europe-west6" },
{ value: "europe-central2", label: "europe-central2" },
{ value: "asia-east1", label: "asia-east1" },
{ value: "asia-east2", label: "asia-east2" },
{ value: "asia-northeast1", label: "asia-northeast1" },
{ value: "asia-northeast2", label: "asia-northeast2" },
{ value: "asia-northeast3", label: "asia-northeast3" },
{ value: "asia-south1", label: "asia-south1" },
{ value: "asia-south2", label: "asia-south2" },
{ value: "asia-southeast1", label: "asia-southeast1" },
{ value: "asia-southeast2", label: "asia-southeast2" },
{ value: "australia-southeast1", label: "australia-southeast1" },
{ value: "australia-southeast2", label: "australia-southeast2" },
{ value: "me-west1", label: "me-west1" },
{ value: "me-central1", label: "me-central1" },
{ value: "africa-south1", label: "africa-south1" },
]
61 changes: 61 additions & 0 deletions webview-ui/src/components/settings/providers/__tests__/Vertex.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
// Tests for VERTEX_REGIONS "global" region handling

import { describe, it, expect } from "vitest"
import { VERTEX_REGIONS } from "../../../../../../packages/types/src/providers/vertex"

describe("VERTEX_REGIONS", () => {
it('should include the "global" region as the first entry', () => {
expect(VERTEX_REGIONS[0]).toEqual({ value: "global", label: "global" })
})

it('should contain "global" region exactly once', () => {
const globalRegions = VERTEX_REGIONS.filter((r: { value: string; label: string }) => r.value === "global")
expect(globalRegions).toHaveLength(1)
})

it('should contain all expected regions including "global"', () => {
// The expected list is the imported VERTEX_REGIONS itself
expect(VERTEX_REGIONS).toEqual([
{ value: "global", label: "global" },
{ value: "us-central1", label: "us-central1" },
{ value: "us-east1", label: "us-east1" },
{ value: "us-east4", label: "us-east4" },
{ value: "us-east5", label: "us-east5" },
{ value: "us-west1", label: "us-west1" },
{ value: "us-west2", label: "us-west2" },
{ value: "us-west3", label: "us-west3" },
{ value: "us-west4", label: "us-west4" },
{ value: "northamerica-northeast1", label: "northamerica-northeast1" },
{ value: "northamerica-northeast2", label: "northamerica-northeast2" },
{ value: "southamerica-east1", label: "southamerica-east1" },
{ value: "europe-west1", label: "europe-west1" },
{ value: "europe-west2", label: "europe-west2" },
{ value: "europe-west3", label: "europe-west3" },
{ value: "europe-west4", label: "europe-west4" },
{ value: "europe-west6", label: "europe-west6" },
{ value: "europe-central2", label: "europe-central2" },
{ value: "asia-east1", label: "asia-east1" },
{ value: "asia-east2", label: "asia-east2" },
{ value: "asia-northeast1", label: "asia-northeast1" },
{ value: "asia-northeast2", label: "asia-northeast2" },
{ value: "asia-northeast3", label: "asia-northeast3" },
{ value: "asia-south1", label: "asia-south1" },
{ value: "asia-south2", label: "asia-south2" },
{ value: "asia-southeast1", label: "asia-southeast1" },
{ value: "asia-southeast2", label: "asia-southeast2" },
{ value: "australia-southeast1", label: "australia-southeast1" },
{ value: "australia-southeast2", label: "australia-southeast2" },
{ value: "me-west1", label: "me-west1" },
{ value: "me-central1", label: "me-central1" },
{ value: "africa-south1", label: "africa-south1" },
])
})

it('should contain "asia-east1" region exactly once', () => {
const asiaEast1Regions = VERTEX_REGIONS.filter(
(r: { value: string; label: string }) => r.value === "asia-east1" && r.label === "asia-east1",
)
expect(asiaEast1Regions).toHaveLength(1)
expect(asiaEast1Regions[0]).toEqual({ value: "asia-east1", label: "asia-east1" })
})
})
Loading