Skip to content

Conversation

@roomote
Copy link
Collaborator

@roomote roomote commented Jul 13, 2025

Summary

This PR fixes the warnings in the publish-nightly workflow logs by removing the invalid skip-checkout parameter from three GitHub Actions workflow files.

Problem

The setup-node-pnpm custom action only accepts these inputs:

  • node-version
  • pnpm-version
  • skip-install
  • install-args

However, three workflow files were passing an invalid skip-checkout parameter, causing warnings in the workflow runs.

Solution

Removed the skip-checkout parameter from:

  • .github/workflows/nightly-publish.yml
  • .github/workflows/marketplace-publish.yml
  • .github/workflows/changeset-release.yml

Since all these workflows already have a separate checkout step before calling the setup action, the skip-checkout parameter was unnecessary.

Testing

  • ✅ All linting checks pass
  • ✅ All type checks pass
  • ✅ No skip-checkout parameters remain in workflow files

Fixes #5674


Important

Remove invalid skip-checkout parameter from GitHub Actions workflows to fix warnings.

  • Behavior:
    • Removed invalid skip-checkout parameter from setup-node-pnpm in .github/workflows/nightly-publish.yml, .github/workflows/marketplace-publish.yml, and .github/workflows/changeset-release.yml.
    • The parameter was unnecessary as a separate checkout step is already present in these workflows.
  • Testing:
    • Verified no skip-checkout parameters remain in workflow files.
    • All linting and type checks pass.

This description was created by Ellipsis for 36f3453. You can customize this summary. It will automatically update as commits are pushed.

…lows

- Removed skip-checkout parameter from nightly-publish.yml
- Removed skip-checkout parameter from marketplace-publish.yml
- Removed skip-checkout parameter from changeset-release.yml

The setup-node-pnpm action only accepts: node-version, pnpm-version, skip-install, and install-args.
The skip-checkout parameter was causing warnings in workflow runs.

Fixes #5674
@roomote roomote requested review from cte, jr and mrubens as code owners July 13, 2025 22:15
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jul 13, 2025
@delve-auditor
Copy link

delve-auditor bot commented Jul 13, 2025

No security or compliance issues detected. Reviewed everything up to 36f3453.

Security Overview
  • 🔎 Scanned files: 3 changed file(s)
Detected Code Changes
Change Type Relevant files
Bug Fix ► .github/workflows/changeset-release.yml
    Remove invalid skip-checkout parameter
► .github/workflows/marketplace-publish.yml
    Remove invalid skip-checkout parameter
► .github/workflows/nightly-publish.yml
    Remove invalid skip-checkout parameter

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 13, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 15, 2025
@mrubens mrubens merged commit 36d56e8 into main Jul 15, 2025
26 checks passed
@mrubens mrubens deleted the fix/remove-invalid-skip-checkout-parameter branch July 15, 2025 00:58
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jul 15, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 15, 2025
fxcl added a commit to tameslabs/Roo-Cline that referenced this pull request Jul 16, 2025
* main:
  fix: Resolve confusing auto-approve checkbox states (RooCodeInc#5602)
  fix: prevent empty mode names from being saved (RooCodeInc#5766) (RooCodeInc#5794)
  Format time in ISO 8601 (RooCodeInc#5793)
  fix: resolve DirectoryScanner memory leak and improve file limit handling (RooCodeInc#5785)
  Fix settings dirty check (RooCodeInc#5779)
  feat: increase Ollama API timeout values and extract as constants (RooCodeInc#5778)
  fix: Exclude Terraform and Terragrunt cache directories from checkpoints (RooCodeInc#4601) (RooCodeInc#5750)
  Move less commonly used provider settings into an advanced dropdown (RooCodeInc#5762)
  feat: Add configurable error & repetition limit with unified control (RooCodeInc#5654) (RooCodeInc#5752)
  list-files must include at least the first-level directory contents (RooCodeInc#5303)
  Update evals repo link (RooCodeInc#5758)
  Feature/vertex ai model name conversion (RooCodeInc#5728)
  fix(litellm): handle baseurl with paths correctly (RooCodeInc#5697)
  Add telemetry for todos (RooCodeInc#5746)
  feat: add undo functionality for enhance prompt feature (fixes RooCodeInc#5741) (RooCodeInc#5742)
  Fix max_tokens limit for moonshotai/kimi-k2-instruct on Groq (RooCodeInc#5740)
  Changeset version bump (RooCodeInc#5735)
  Add changeset for v3.23.12 patch release (RooCodeInc#5734)
  Update the max-token calculation in model-params to use the shared logic (RooCodeInc#5720)
  Changeset version bump (RooCodeInc#5719)
  chore: add changeset for v3.23.11 patch release (RooCodeInc#5718)
  Add Kimi K2 model and better support (RooCodeInc#5717)
  Fix: Remove invalid skip-checkout parameter from GitHub Actions workflows (RooCodeInc#5676)
  feat: add Cmd+Shift+. keyboard shortcut for previous mode switching (RooCodeInc#5695)
  Changeset version bump (RooCodeInc#5708)
  chore: add changeset for v3.23.10 patch release (RooCodeInc#5707)
  Add padding to the index model options (RooCodeInc#5706)
  fix: prioritize built-in model dimensions over custom dimensions (RooCodeInc#5705)
  Update CHANGELOG.md
  Changeset version bump (RooCodeInc#5702)
  chore: add changeset for v3.23.9 patch release (RooCodeInc#5701)
  Tweaks to command timeout error (RooCodeInc#5700)
  Update contributors list (RooCodeInc#5639)
  feat: enable Claude Code provider to run natively on Windows (RooCodeInc#5615)
  feat: Add configurable timeout for command execution (RooCodeInc#5668)
  feat: add gemini-embedding-001 model to code-index service (RooCodeInc#5698)
  fix: resolve vector dimension mismatch error when switching embedding models (RooCodeInc#5616) (RooCodeInc#5617)
  fix: [5424] return the cwd in the exec tool's response so that the model is not lost after subsequent calls (RooCodeInc#5667)
  Changeset version bump (RooCodeInc#5670)
  chore: add changeset for v3.23.8 patch release (RooCodeInc#5669)
Copy link

@ammetha1997-lgtm ammetha1997-lgtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_20251203_200526_com_microsoft_emmx_CustomTabActivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

The publish-nightly logs have 2 warnings

6 participants