feat: Replace image-only attachment with general file attachment support (#5532) #5908

roomote · 2025-07-18T17:36:44Z

This PR implements general file attachment support to replace the current image-only attachment system while maintaining full backward compatibility.

🎯 Overview

Replaces the camera icon with a paperclip icon and extends file support beyond images to include documents, code files, data files, archives, and configuration files.

✨ Key Features

Comprehensive File Processing: New process-files.ts module with intelligent MIME type detection
Multiple File Categories: Support for images, documents, code, data, archives, and config files
Smart Content Handling: Text files as content, binary files as base64
File Size Validation: 10MB limit with user-friendly error messages
UI Updates: Paperclip icon replaces camera icon with updated tooltips
Internationalization: Added "attachFiles" translation key across all languages
Backward Compatibility: Existing image functionality continues to work seamlessly

🔧 Technical Implementation

Added selectFiles message types to WebviewMessage.ts and ExtensionMessage.ts
Updated webviewMessageHandler.ts to handle file selection workflow
Modified ChatTextArea.tsx and ChatView.tsx for new file attachment UI
Comprehensive file processing with MIME type detection and categorization

🧪 Testing

Maintains existing image attachment functionality
Supports all major file types with appropriate processing
Validates file sizes and provides clear error feedback

📝 Files Changed

src/integrations/misc/process-files.ts (new)
src/shared/WebviewMessage.ts
src/shared/ExtensionMessage.ts
src/core/webview/webviewMessageHandler.ts
webview-ui/src/components/chat/ChatTextArea.tsx
webview-ui/src/components/chat/ChatView.tsx
Translation files across all languages

Resolves #5532

Important

This PR replaces image-only attachment with general file attachment support, updates UI components, and adds internationalization for file attachments.

Behavior:
- Replaces image-only attachment with general file attachment support, maintaining backward compatibility.
- Supports images, documents, code, data, archives, and config files.
- Text files are processed as content, binary files as base64.
- File size limit set to 10MB with error messages.
UI Updates:
- Replaces camera icon with paperclip icon in ChatTextArea.tsx and ChatView.tsx.
- Updates tooltips and adds attachFiles translation key.
Technical Implementation:
- Adds process-files.ts for file processing with MIME type detection.
- Updates webviewMessageHandler.ts to handle file selection.
- Adds selectFiles message types to WebviewMessage.ts and ExtensionMessage.ts.
Internationalization:
- Adds "attachFiles" translation key across all languages.

^{This description was created by}^{for 53422d3. You can customize this summary. It will automatically update as commits are pushed.}

- Add comprehensive file processing system with MIME type detection - Support multiple file categories (images, documents, code, data, archives, config) - Implement 10MB file size limit and intelligent text/binary handling - Replace camera icon with paperclip icon in chat interface - Add selectFiles message types and handlers - Update translations for attachFiles across all languages - Maintain backward compatibility with existing image functionality Resolves #5532

ellipsis-dev · 2025-07-18T17:38:43Z

webview-ui/src/i18n/locales/zh-TW/chat.json

 	"selectApiConfig": "選取 API 設定",
 	"enhancePrompt": "使用額外內容增強提示",
 	"addImages": "新增圖片到訊息中",
+	"attachFiles": "Attach files to message",


The 'attachFiles' key still contains English text ('Attach files to message'). Please provide a proper Traditional Chinese translation (e.g., '將檔案附加到訊息') to maintain consistency with the localized content.

Suggested change

"attachFiles": "Attach files to message",

"attachFiles": "將檔案附加到訊息",

ellipsis-dev · 2025-07-18T17:38:43Z

webview-ui/src/i18n/locales/ca/chat.json

 	"selectApiConfig": "Seleccioneu la configuració de l'API",
 	"enhancePrompt": "Millora la sol·licitud amb context addicional",
 	"addImages": "Afegeix imatges al missatge",
+	"attachFiles": "Attach files to message",


It appears that the new key "attachFiles" still uses an English phrase ('Attach files to message') in a Catalan locale file. Please update it to a Catalan translation.

Suggested change

"attachFiles": "Attach files to message",

"attachFiles": "Adjunta fitxers al missatge",

^{This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.}

ellipsis-dev · 2025-07-18T17:38:43Z

webview-ui/src/i18n/locales/de/chat.json

 	"selectApiConfig": "API-Konfiguration auswählen",
 	"enhancePrompt": "Prompt mit zusätzlichem Kontext verbessern",
 	"addImages": "Bilder zur Nachricht hinzufügen",
+	"attachFiles": "Attach files to message",


Typographical Note: The value for the key "attachFiles" is in English, which is inconsistent with the rest of the German locale file. Consider providing the correct German translation, e.g., "Dateien zur Nachricht anhängen".

Suggested change

"attachFiles": "Attach files to message",

"attachFiles": "Dateien zur Nachricht anhängen",

^{This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.}

ellipsis-dev · 2025-07-18T17:38:44Z

webview-ui/src/i18n/locales/fr/chat.json

 	"selectApiConfig": "Sélectionner la configuration de l'API",
 	"enhancePrompt": "Améliorer la requête avec un contexte supplémentaire",
 	"addImages": "Ajouter des images au message",
+	"attachFiles": "Attach files to message",


The new key 'attachFiles' has an English string in a French localization file. Consider translating it to French (e.g. "Joindre des fichiers au message") for consistency.

Suggested change

"attachFiles": "Attach files to message",

"attachFiles": "Joindre des fichiers au message",

^{This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.}

ellipsis-dev · 2025-07-18T17:38:44Z

webview-ui/src/i18n/locales/nl/chat.json

 		"description": "Gespecialiseerde persona's die het gedrag van Roo aanpassen."
 	},
 	"addImages": "Afbeeldingen toevoegen aan bericht",
+	"attachFiles": "Attach files to message",


The translation for 'attachFiles' is still in English ('Attach files to message') while the rest of the file is in Dutch. Please verify if this is intentional or if it should be translated (e.g., "Bestanden toevoegen aan bericht").

Suggested change

"attachFiles": "Attach files to message",

"attachFiles": "Bestanden toevoegen aan bericht",

^{This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.}

ellipsis-dev · 2025-07-18T17:38:44Z

webview-ui/src/i18n/locales/pl/chat.json

 	"selectApiConfig": "Wybierz konfigurację API",
 	"enhancePrompt": "Ulepsz podpowiedź dodatkowym kontekstem",
 	"addImages": "Dodaj obrazy do wiadomości",
+	"attachFiles": "Attach files to message",


The new entry, "Attach files to message," appears in English in a Polish locale file. This seems out of place given the other translations. Please consider providing the appropriate Polish translation (e.g., "Załącz pliki do wiadomości").

Suggested change

"attachFiles": "Attach files to message",

"attachFiles": "Załącz pliki do wiadomości",

^{This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.}

ellipsis-dev · 2025-07-18T17:38:44Z

webview-ui/src/i18n/locales/pt-BR/chat.json

 	"selectApiConfig": "Selecionar configuração da API",
 	"enhancePrompt": "Aprimorar prompt com contexto adicional",
 	"addImages": "Adicionar imagens à mensagem",
+	"attachFiles": "Attach files to message",


Typographical note: The value for attachFiles is in English ('Attach files to message') while the rest of the translations are in Portuguese. Consider translating it (e.g., 'Anexar arquivos à mensagem') for language consistency.

Suggested change

"attachFiles": "Attach files to message",

"attachFiles": "Anexar arquivos à mensagem",

^{This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.}

ellipsis-dev · 2025-07-18T17:38:44Z

webview-ui/src/i18n/locales/tr/chat.json

 	"selectApiConfig": "API yapılandırmasını seçin",
 	"enhancePrompt": "Ek bağlamla istemi geliştir",
 	"addImages": "Mesaja resim ekle",
+	"attachFiles": "Attach files to message",


The new translation for "attachFiles" is in English. Considering this file is for Turkish locales, please provide a Turkish translation for consistency (e.g., "Mesaja dosya ekle").

Suggested change

"attachFiles": "Attach files to message",

"attachFiles": "Mesaja dosya ekle",

^{This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.}

daniel-lxs · 2025-07-19T22:25:47Z

Closing, see #5570 (comment)

roomote bot requested review from cte, jr and mrubens as code owners July 18, 2025 17:36

github-project-automation bot added this to Roo Code Roadmap and Roo Code Roadmap Jul 18, 2025

github-project-automation bot moved this to Triage in Roo Code Roadmap Jul 18, 2025

github-project-automation bot moved this to New in Roo Code Roadmap Jul 18, 2025

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request UI/UX UI/UX related or focused labels Jul 18, 2025

roomote bot mentioned this pull request Jul 18, 2025

feat: Replace image-only attachment with general file attachment support (#5532) #5533

Closed

14 tasks

ellipsis-dev bot reviewed Jul 18, 2025

View reviewed changes

hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 18, 2025

daniel-lxs closed this Jul 19, 2025

github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jul 19, 2025

github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Replace image-only attachment with general file attachment support (#5532) #5908

feat: Replace image-only attachment with general file attachment support (#5532) #5908

Uh oh!

roomote bot commented Jul 18, 2025 •

edited by ellipsis-dev bot

Loading

Uh oh!

ellipsis-dev bot Jul 18, 2025

Uh oh!

ellipsis-dev bot Jul 18, 2025

Uh oh!

ellipsis-dev bot Jul 18, 2025

Uh oh!

ellipsis-dev bot Jul 18, 2025

Uh oh!

ellipsis-dev bot Jul 18, 2025

Uh oh!

ellipsis-dev bot Jul 18, 2025

Uh oh!

ellipsis-dev bot Jul 18, 2025

Uh oh!

ellipsis-dev bot Jul 18, 2025

Uh oh!

daniel-lxs commented Jul 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	"attachFiles": "Attach files to message",
	"attachFiles": "將檔案附加到訊息",

	"attachFiles": "Attach files to message",
	"attachFiles": "Adjunta fitxers al missatge",

	"attachFiles": "Attach files to message",
	"attachFiles": "Dateien zur Nachricht anhängen",

	"attachFiles": "Attach files to message",
	"attachFiles": "Joindre des fichiers au message",

	"attachFiles": "Attach files to message",
	"attachFiles": "Bestanden toevoegen aan bericht",

	"attachFiles": "Attach files to message",
	"attachFiles": "Załącz pliki do wiadomości",

	"attachFiles": "Attach files to message",
	"attachFiles": "Anexar arquivos à mensagem",

	"attachFiles": "Attach files to message",
	"attachFiles": "Mesaja dosya ekle",

feat: Replace image-only attachment with general file attachment support (#5532) #5908

feat: Replace image-only attachment with general file attachment support (#5532) #5908

Uh oh!

Conversation

roomote bot commented Jul 18, 2025 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Overview

✨ Key Features

🔧 Technical Implementation

🧪 Testing

📝 Files Changed

Uh oh!

ellipsis-dev bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

daniel-lxs commented Jul 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

roomote bot commented Jul 18, 2025 •

edited by ellipsis-dev bot

Loading