feat: add MySQL MCP server package #6202
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement MySQL MCP server with connection pooling - Add tools for query execution, database/table listing, and schema inspection - Support both SELECT queries and data modification operations - Include comprehensive documentation and TypeScript types - Add basic test structure Closes #6201
dosubot
bot
added
size:XL
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| await connection.changeUser({ database }) | ||
| } | ||
|
|
||
| const [rows, fields] = (await connection.execute(`DESCRIBE ${table}`)) as [ |
Contributor
There was a problem hiding this comment.
Potential SQL injection risk: the table name is interpolated directly in the DESCRIBE query. Consider sanitizing it (e.g., using mysql.escapeId() or validating allowed characters).
Suggested change
| const [rows, fields] = (await connection.execute(`DESCRIBE ${table}`)) as [ | |
| const [rows, fields] = (await connection.execute(`DESCRIBE ${mysql.escapeId(table)}`)) as [ |
| if (database) { | ||
| await connection.changeUser({ database }) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
For the 'execute' tool, dynamic SQL is executed directly. Consider advising users to use parameterized queries or proper sanitization when constructing dynamic SQL to prevent injection risks.
hannesrudolph
added
the
Issue/PR - Triage
Member
|
Not what the issue was created for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a MySQL MCP (Model Context Protocol) server as requested in #6201.
Summary
Added a new package
@roo-code/mcp-server-mysqlthat provides MySQL database operations through the MCP protocol.Features
query- Execute SELECT queries safelyexecute- Execute INSERT, UPDATE, DELETE, and DDL operationslist_databases- List all databaseslist_tables- List tables in a databasedescribe_table- Get table structuretest_connection- Test database connectivityquery) and write (execute) operationsConfiguration
The server uses environment variables for configuration:
MYSQL_HOST- MySQL server host (default: localhost)MYSQL_PORT- MySQL server port (default: 3306)MYSQL_USER- MySQL username (default: root)MYSQL_PASSWORD- MySQL passwordMYSQL_DATABASE- Default database (optional)Testing
Basic test structure is included. The implementation follows the project's patterns and conventions.
Closes #6201
Important
Adds
@roo-code/mcp-server-mysqlpackage for MySQL operations via MCP with connection pooling, query tools, and TypeScript support.@roo-code/mcp-server-mysqlfor MySQL operations via MCP.query,execute,list_databases,list_tables,describe_table,test_connection.query) and write (execute) operations.MYSQL_HOST,MYSQL_PORT,MYSQL_USER,MYSQL_PASSWORD,MYSQL_DATABASE.index.test.tsfor server instance and tool registration.README.md.eslint.config.mjs.package.json.This description was created by
for 1a42981. You can customize this summary. It will automatically update as commits are pushed.