-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add spell check feature to Roo Chat #6254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add experimental spell check feature flag - Implement spell check utility with basic dictionary - Integrate spell check highlighting in ChatTextArea component - Add CSS styles for red wavy underlines on misspelled words - Add comprehensive tests for spell check functionality - Add i18n translations for the feature This feature helps users identify misspelled words in the chat interface by highlighting them with red wavy underlines, similar to standard text editors.
|
@roomote-agent I was thinking more so where it allowed the systems spellcheck service to handle it. Scrap this PR and start over. |
|
Hi @hannesrudolph, I understand. You want to use the native browser spellcheck functionality instead of a custom dictionary implementation. I'll scrap the current approach and implement it using the system's built-in spell check service. Working on it now! |
- Remove custom spell check implementation (spellCheck.ts and tests) - Use native spellcheck attribute on textarea element - Remove custom spell check CSS styles - Update translation to reflect native browser spell check usage - Simplify ChatTextArea component by removing spell check logic As requested by @hannesrudolph, this implementation now uses the system's native spell check service instead of a custom dictionary-based approach.
- Add English placeholder translations for spell check feature to all locale files - This fixes the failing translation check in CI - Actual translations can be provided by translators later
|
Hi @hannesrudolph, I've successfully updated the spell check implementation to use the browser's native spell check service as requested. Summary of changes:
The implementation is now much simpler and leverages the system's built-in spell check capabilities, which should provide better language support and user experience. All tests are passing and the translation checks have been fixed. The PR is ready for review! |
| "name": "啟用並行檔案編輯", | ||
| "description": "啟用後 Roo 可在單個請求中編輯多個檔案。停用後 Roo 必須逐個編輯檔案。停用此功能有助於使用能力較弱的模型或需要更精確控制檔案修改時。" | ||
| }, | ||
| "SPELL_CHECK": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The newly added SPELL_CHECK key remains in English. Please provide proper Traditional Chinese translations for the 'name' and 'description' fields.
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
|
@roomote-agent close this Pr and start a new one. This is not an experimental feature. |
|
Acknowledged. I will close this PR and create a new one with the spell check feature implemented as a standard feature rather than experimental. Working on it now. |
|
Closing this PR as requested. Will create a new PR with spell check as a standard feature instead of experimental. |
|
I have closed this PR and created a new one with spell check as a standard feature: #6256 The new PR removes spell check from the experimental features list and enables it by default in the chat textarea. All references to the experimental flag have been removed from the codebase and locale files. Note: There is currently one failing integration test in the CI, but this appears to be unrelated to the spell check changes as all other checks are passing. |
This PR adds a spell check feature to the Roo Chat interface to help users identify misspelled words.
Summary of Changes
How it Works
When the spell check feature is enabled in experimental settings:
Testing
This addresses the user request to have spell checking in the Roo chat interface, similar to standard text editors.
Important
This PR adds an experimental spell check feature to Roo Chat, highlighting misspelled words in real-time and supporting multiple languages.
ChatTextAreawith red wavy underlines.@mentionsand/commandsduring spell check.ChatTextArea.tsx.This description was created by
for dae2e34. You can customize this summary. It will automatically update as commits are pushed.