Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Jul 26, 2025

This PR adds spell check as a standard feature to the Roo Chat interface, removing it from experimental features.

Summary of Changes

  • Standard Feature: Spell check is now enabled by default in the chat textarea
  • Removed Experimental Flag: Removed spell check from the experimental features list
  • Updated Types: Removed spellCheck from ExperimentId and Experiments types
  • Updated Tests: Updated all tests to reflect the removal of the experimental flag
  • Updated Locales: Removed spell check references from all 18 locale files

How it Works

Spell check is now always enabled in the chat textarea using the browser's native spell check functionality (spellCheck={true}). Users will see red wavy underlines for misspelled words as they type.

Testing

  • All existing tests pass
  • Type checking passes
  • Linting passes

This addresses the request from @hannesrudolph to make spell check a standard feature rather than experimental.

Closes #6254


Important

Spell check is now a standard feature in Roo Chat, enabled by default and removed from experimental features.

  • Behavior:
    • Spell check enabled by default in ChatTextArea using spellCheck={true}.
    • Removed from experimental features list.
  • Types:
    • Removed spellCheck from ExperimentId and Experiments types.
  • Tests:
    • Updated tests in ExtensionStateContext.spec.tsx to reflect removal of experimental flag.
  • Locales:
    • Removed spell check references from 18 locale files.

This description was created by Ellipsis for ad848ac. You can customize this summary. It will automatically update as commits are pushed.

roomote added 4 commits July 26, 2025 22:36
- Add experimental spell check feature flag
- Implement spell check utility with basic dictionary
- Integrate spell check highlighting in ChatTextArea component
- Add CSS styles for red wavy underlines on misspelled words
- Add comprehensive tests for spell check functionality
- Add i18n translations for the feature

This feature helps users identify misspelled words in the chat interface
by highlighting them with red wavy underlines, similar to standard text
editors.
- Remove custom spell check implementation (spellCheck.ts and tests)
- Use native spellcheck attribute on textarea element
- Remove custom spell check CSS styles
- Update translation to reflect native browser spell check usage
- Simplify ChatTextArea component by removing spell check logic

As requested by @hannesrudolph, this implementation now uses the system's native spell check service instead of a custom dictionary-based approach.
- Add English placeholder translations for spell check feature to all locale files
- This fixes the failing translation check in CI
- Actual translations can be provided by translators later
- Remove spell check from experimental features list
- Enable spell check by default in ChatTextArea
- Remove spell check references from all locale files
- Update tests to reflect the changes
@roomote roomote bot requested review from cte, jr and mrubens as code owners July 26, 2025 22:59
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Jul 26, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 26, 2025
@mrubens
Copy link
Collaborator

mrubens commented Jul 26, 2025

Pretty sure I've tried this before and it doesn't work, sadly

@hannesrudolph
Copy link
Collaborator

Pretty sure I've tried this before and it doesn't work, sadly

@roomote-agent address this

@roomote
Copy link
Contributor Author

roomote bot commented Jul 26, 2025

I see the concern about spell check not working. Let me investigate this issue and verify the implementation to ensure it works correctly across different environments.

…ebview limitation

- Removed spellCheck={true} from ChatTextArea as it does not work in VSCode webviews
- Added comment explaining the limitation with reference to VSCode issue #30180
- This addresses the concern raised by @mrubens about spell check not working
@roomote
Copy link
Contributor Author

roomote bot commented Jul 26, 2025

@mrubens You are correct - native browser spell check does not work in VSCode webviews due to platform limitations. This is a known issue with VSCode's webview implementation (see microsoft/vscode#30180).

I've updated the PR to:

  1. Remove the non-functional spellCheck={true} attribute from the ChatTextArea component
  2. Add a comment explaining why spell check doesn't work, with a reference to the VSCode issue

This way, future developers won't be confused about why spell check isn't working. Unfortunately, implementing a custom spell check solution would require significant effort and external libraries, which is beyond the scope of this PR.

The feature request to add spell check as a standard feature cannot be fulfilled due to this VSCode limitation.

@daniel-lxs
Copy link
Member

Closing

@daniel-lxs daniel-lxs closed this Jul 29, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 29, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants