-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: Add spell check as standard feature #6256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add experimental spell check feature flag - Implement spell check utility with basic dictionary - Integrate spell check highlighting in ChatTextArea component - Add CSS styles for red wavy underlines on misspelled words - Add comprehensive tests for spell check functionality - Add i18n translations for the feature This feature helps users identify misspelled words in the chat interface by highlighting them with red wavy underlines, similar to standard text editors.
- Remove custom spell check implementation (spellCheck.ts and tests) - Use native spellcheck attribute on textarea element - Remove custom spell check CSS styles - Update translation to reflect native browser spell check usage - Simplify ChatTextArea component by removing spell check logic As requested by @hannesrudolph, this implementation now uses the system's native spell check service instead of a custom dictionary-based approach.
- Add English placeholder translations for spell check feature to all locale files - This fixes the failing translation check in CI - Actual translations can be provided by translators later
- Remove spell check from experimental features list - Enable spell check by default in ChatTextArea - Remove spell check references from all locale files - Update tests to reflect the changes
|
Pretty sure I've tried this before and it doesn't work, sadly |
@roomote-agent address this |
|
I see the concern about spell check not working. Let me investigate this issue and verify the implementation to ensure it works correctly across different environments. |
…ebview limitation
- Removed spellCheck={true} from ChatTextArea as it does not work in VSCode webviews
- Added comment explaining the limitation with reference to VSCode issue #30180
- This addresses the concern raised by @mrubens about spell check not working
|
@mrubens You are correct - native browser spell check does not work in VSCode webviews due to platform limitations. This is a known issue with VSCode's webview implementation (see microsoft/vscode#30180). I've updated the PR to:
This way, future developers won't be confused about why spell check isn't working. Unfortunately, implementing a custom spell check solution would require significant effort and external libraries, which is beyond the scope of this PR. The feature request to add spell check as a standard feature cannot be fulfilled due to this VSCode limitation. |
|
Closing |
This PR adds spell check as a standard feature to the Roo Chat interface, removing it from experimental features.
Summary of Changes
spellCheckfromExperimentIdandExperimentstypesHow it Works
Spell check is now always enabled in the chat textarea using the browser's native spell check functionality (
spellCheck={true}). Users will see red wavy underlines for misspelled words as they type.Testing
This addresses the request from @hannesrudolph to make spell check a standard feature rather than experimental.
Closes #6254
Important
Spell check is now a standard feature in Roo Chat, enabled by default and removed from experimental features.
ChatTextAreausingspellCheck={true}.spellCheckfromExperimentIdandExperimentstypes.ExtensionStateContext.spec.tsxto reflect removal of experimental flag.This description was created by
for ad848ac. You can customize this summary. It will automatically update as commits are pushed.