-
Notifications
You must be signed in to change notification settings - Fork 2.6k
remove: Cleanup gemini cli leftovers #6383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… Anthropic API usage - Remove gemini-cli from provider names list and discriminated union - Fix buildApiHandler default case to use claude-code instead of anthropic when provider is undefined - Add proper error handling for unknown providers instead of silently defaulting to Anthropic - This prevents Claude Code from incorrectly using user Anthropic API keys Fixes #6382
|
@roomote-agent revert the change to the default case completely please, do not create a new PR |
|
I understand. I will revert the change to the default case completely and push the changes to this same PR branch. |
|
Done! I have reverted the default case in buildApiHandler back to its original state as requested. The change restores the original behavior: default:
apiProvider satisfies "gemini-cli" | undefined
return new AnthropicHandler(options)The modification has been pushed to this PR branch and CI checks are running. Local tests passed successfully. |
|
@roomote-agent Now make it look like this: Push to this PR, do not create a new one |
|
I see the request to change the default case to |
|
Done! ✅ I have simplified the default case in the Changes made:
Testing:
The modification aligns with the PR's goal of cleaning up references to the removed |
daniel-lxs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@roomote-agent make sure no errors occur if a user has a removed provider selected, make sure it fallback to the first provider in the list, do not create a new PR, push to this one |
|
Hi @daniel-lxs! I see your request. I will implement the fallback logic to ensure that if a user has a removed provider (like gemini-cli) selected, it will gracefully fallback to the first available provider in the list. Working on this now and will push the changes to this PR branch. |
- Add validation in webviewDidLaunch to check if current provider is still supported - Add validation in activateProviderProfile to prevent activation of removed providers - Automatically fallback to first available valid provider when removed provider is detected - Show warning message to user when provider is switched due to removal - Add comprehensive tests for provider fallback behavior This ensures users with removed providers (like gemini-cli) will automatically be switched to a valid provider instead of encountering errors.
|
@daniel-lxs I've implemented the fallback mechanism as requested! 🎯 Implementation SummaryI added validation logic to ensure users with removed providers (like "gemini-cli") are automatically switched to a valid provider: Changes Made:
How It Works:When a user with "gemini-cli" (or any removed provider) selected opens the extension:
All tests are passing ✅ and the changes have been pushed to this PR branch as requested! |
Remove leftover Gemini CLI code