-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix: enable model selection dropdown for Fireworks AI provider #6755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Move Fireworks component rendering to after model dropdown section - This allows users to see all available Fireworks models - Users can now select custom models by typing in the search field - Fixes #6753
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed my own code and found it adequate. The bar was low, and I barely cleared it.
| )} | ||
|
|
||
| {selectedProvider === "fireworks" && ( | ||
| <Fireworks apiConfiguration={apiConfiguration} setApiConfigurationField={setApiConfigurationField} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this placement intentional? I notice most other provider-specific components are rendered before the model dropdown section, but placing Fireworks after actually makes sense since users need to see available models before entering their API key. Just wanted to confirm this was a deliberate design choice.
| </> | ||
| )} | ||
|
|
||
| {selectedProvider === "fireworks" && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a comment here explaining why the Fireworks component needs to be rendered after the model dropdown section. This would help prevent someone from accidentally moving it back in the future:
|
This is not what the issue is referring to |
This PR fixes the issue where Fireworks AI provider was not showing the model selection dropdown, limiting users to only the predefined models without the ability to add custom models.
Changes
Testing
Fixes #6753
Important
Moves
Fireworkscomponent rendering inApiOptions.tsxto enable model selection dropdown for Fireworks provider.Fireworkscomponent rendering after model dropdown inApiOptions.tsx.This description was created by
for dcf501f. You can customize this summary. It will automatically update as commits are pushed.