Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Aug 6, 2025

This PR fixes the issue where Fireworks AI provider was not showing the model selection dropdown, limiting users to only the predefined models without the ability to add custom models.

Changes

  • Moved the Fireworks component rendering to after the model dropdown section in ApiOptions.tsx
  • This allows the model dropdown to be displayed for Fireworks provider
  • Users can now see all available Fireworks models (Kimi K2, Qwen3 235b, Qwen3 Coder, Deepseek r1, Deepseek v3)
  • Users can also type custom model IDs in the search field to use models not in the predefined list

Testing

  • All existing tests pass
  • Manually tested that the model dropdown now appears for Fireworks provider
  • Verified that custom models can be entered via the search field

Fixes #6753


Important

Moves Fireworks component rendering in ApiOptions.tsx to enable model selection dropdown for Fireworks provider.

  • Behavior:
    • Moves Fireworks component rendering after model dropdown in ApiOptions.tsx.
    • Enables model selection dropdown for Fireworks provider, showing models like Kimi K2, Qwen3 235b, etc.
    • Allows custom model IDs input in the search field.
  • Testing:
    • All existing tests pass.
    • Manually verified model dropdown appearance and custom model input for Fireworks provider.

This description was created by Ellipsis for dcf501f. You can customize this summary. It will automatically update as commits are pushed.

- Move Fireworks component rendering to after model dropdown section
- This allows users to see all available Fireworks models
- Users can now select custom models by typing in the search field
- Fixes #6753
@roomote roomote bot requested review from cte, jr and mrubens as code owners August 6, 2025 16:46
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Aug 6, 2025
Copy link
Contributor Author

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed my own code and found it adequate. The bar was low, and I barely cleared it.

)}

{selectedProvider === "fireworks" && (
<Fireworks apiConfiguration={apiConfiguration} setApiConfigurationField={setApiConfigurationField} />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this placement intentional? I notice most other provider-specific components are rendered before the model dropdown section, but placing Fireworks after actually makes sense since users need to see available models before entering their API key. Just wanted to confirm this was a deliberate design choice.

</>
)}

{selectedProvider === "fireworks" && (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a comment here explaining why the Fireworks component needs to be rendered after the model dropdown section. This would help prevent someone from accidentally moving it back in the future:

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Aug 6, 2025
@daniel-lxs
Copy link
Member

This is not what the issue is referring to

@daniel-lxs daniel-lxs closed this Aug 7, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Aug 7, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

For Fireworks.ai, limited number of models is listed

4 participants