Skip to content

fix: enable model selection dropdown for Fireworks AI provider #6755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: enable model selection dropdown for Fireworks AI provider #6755

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions webview-ui/src/components/settings/ApiOptions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,10 +558,6 @@ const ApiOptions = ({
</>
)}

{selectedProvider === "fireworks" && (
<Fireworks apiConfiguration={apiConfiguration} setApiConfigurationField={setApiConfigurationField} />
)}

{selectedProviderModels.length > 0 && (
<>
<div>
Expand Down Expand Up @@ -609,6 +605,10 @@ const ApiOptions = ({
</>
)}

{selectedProvider === "fireworks" && (
Copy link
Contributor Author

@roomote roomote bot Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a comment here explaining why the Fireworks component needs to be rendered after the model dropdown section. This would help prevent someone from accidentally moving it back in the future:

<Fireworks apiConfiguration={apiConfiguration} setApiConfigurationField={setApiConfigurationField} />
Copy link
Contributor Author

@roomote roomote bot Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this placement intentional? I notice most other provider-specific components are rendered before the model dropdown section, but placing Fireworks after actually makes sense since users need to see available models before entering their API key. Just wanted to confirm this was a deliberate design choice.

)}

<ThinkingBudget
key={`${selectedProvider}-${selectedModelId}`}
apiConfiguration={apiConfiguration}
Expand Down
Loading