fix: reset condensing state when switching tasks #6922
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when users initiated context condensing and switched to another task before completion, the 'condensing context' indicator would persist on the new task. This fix ensures the condensing state is properly reset in the task switching effect, preventing the indicator from appearing incorrectly on different tasks.
dosubot
bot
added
size:XS
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Thank you for your contribution! This is a clean, targeted fix that properly addresses the bug described in issue #6919. The implementation is correct and follows the existing patterns in the codebase. I have one suggestion for improvement regarding test coverage.
| setExpandedRows({}) | ||
| everVisibleMessagesTsRef.current.clear() // Clear for new task | ||
| setCurrentFollowUpTs(null) // Clear follow-up answered state for new task | ||
| setIsCondensing(false) // Reset condensing state when switching tasks |
Contributor
There was a problem hiding this comment.
Good fix! The placement here with other UI state resets is logical and maintains consistency. However, would you consider adding a test case to verify that is properly reset when switching tasks? This would help prevent regression of this bug in the future.
You could add a test in one of the existing ChatView test files that:
- Sets up a task with set to true
- Switches to a different task
- Verifies that is reset to false
hannesrudolph
added
the
Issue/PR - Triage
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
daniel-lxs
approved these changes
Aug 14, 2025
Member
daniel-lxs
left a comment
daniel-lxs
left a comment
There was a problem hiding this comment.
Thank you @f14XuanLv for your contribution!
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Needs Review]
in Roo Code Roadmap
mrubens
approved these changes
Aug 14, 2025
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
fxcl
added a commit
to tameslabs/Roo-Cline
that referenced
this pull request
Aug 16, 2025
* main: (70 commits) fix: use native Ollama API instead of OpenAI compatibility layer (RooCodeInc#7137) feat: add support for OpenAI gpt-5-chat-latest model (RooCodeInc#7058) Make enhance with task history default to true (RooCodeInc#7140) Bump cloud version to 0.16.0 (RooCodeInc#7135) Release: v1.51.0 (RooCodeInc#7130) Add an API for resuming tasks by ID (RooCodeInc#7122) Add support for task page event population (RooCodeInc#7117) fix: add type check before calling .match() on diffItem.content (RooCodeInc#6905) (RooCodeInc#6906) Fix: Enable save button for provider dropdown and checkbox changes (RooCodeInc#7113) fix: Use cline.cwd as primary source for workspace path in codebaseSearchTool (RooCodeInc#6902) Hotfix multiple folder workspace checkpoint (RooCodeInc#6903) fix: prevent XML entity decoding in diff tools (RooCodeInc#7107) (RooCodeInc#7108) Refactor task execution system: improve call stack management (RooCodeInc#7035) Changeset version bump (RooCodeInc#7104) feat(web): fill missing SEO-related values (RooCodeInc#7096) Update contributors list (RooCodeInc#6883) Release v3.25.15 (RooCodeInc#7103) fix: add /evals page to sitemap generation (RooCodeInc#7102) feat: implement sitemap generation in TypeScript and remove XML file (RooCodeInc#6206) fix: reset condensing state when switching tasks (RooCodeInc#6922) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #6919
Roo Code Task Context (Optional)
N/A
Description
This PR fixes a UI state management issue where the context condensing indicator persists incorrectly when switching between tasks.
The fix adds
setIsCondensing(false)to the task switching effect inChatView.tsx, ensuring the condensing state is properly reset when users switch tasks. The change is minimal and focused - just one line of code with appropriate comments.Test Procedure
Pre-Submission Checklist
Screenshots / Videos
N/A - This is a state management fix with no visual UI changes, only behavioral correction.
Documentation Updates
Additional Notes
webview-ui/src/components/chat/ChatView.tsx(line 440)sendingDisabledGet in Touch
N/A - Available via GitHub @f14XuanLv
Important
Fixes UI state issue in
ChatView.tsxby resettingisCondensingwhen switching tasks to prevent indicator persistence.ChatView.tsxby resettingisCondensingtofalsewhen switching tasks.setIsCondensing(false)in the task switchinguseEffectinChatView.tsx.sendingDisabledis not reset.This description was created by
for 872bf4a. You can customize this summary. It will automatically update as commits are pushed.