Skip to content

fix: reset condensing state when switching tasks #6922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2025
+3 −0
Merged

fix: reset condensing state when switching tasks #6922

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions webview-ui/src/components/chat/ChatView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,9 +434,12 @@ const ChatViewComponent: React.ForwardRefRenderFunction<ChatViewRef, ChatViewPro
}, [messages.length])

useEffect(() => {
// Reset UI states
setExpandedRows({})
everVisibleMessagesTsRef.current.clear() // Clear for new task
setCurrentFollowUpTs(null) // Clear follow-up answered state for new task
setIsCondensing(false) // Reset condensing state when switching tasks
Copy link
Contributor

@roomote roomote bot Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix! The placement here with other UI state resets is logical and maintains consistency. However, would you consider adding a test case to verify that is properly reset when switching tasks? This would help prevent regression of this bug in the future.

You could add a test in one of the existing ChatView test files that:

  1. Sets up a task with set to true
  2. Switches to a different task
  3. Verifies that is reset to false

// Note: sendingDisabled is not reset here as it's managed by message effects

// Clear any pending auto-approval timeout from previous task
if (autoApproveTimeoutRef.current) {
Expand Down
Loading