Skip to content

Conversation

PeterDaveHello
Copy link

@PeterDaveHello PeterDaveHello commented Aug 11, 2025

Description

Update and improve zh-TW Traditional Chinese locale

Test Procedure

Lint JSON locale files syntax and run all the tests

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Documentation Updates

  • No documentation updates are required.
  • Yes, documentation updates are required.

Get in Touch

Discord username: PeterDaveHello


Important

Update and improve Traditional Chinese locale files for better translation accuracy and consistency across the application.

  • Localization Updates:
    • Corrects and improves translations in account.json, chat.json, common.json, history.json, humanRelay.json, marketplace.json, mcp.json, prompts.json, settings.json, and welcome.json.
    • Ensures consistency in terminology, such as using "帳號" for "account" and "連線" for "connect".
    • Updates phrasing for clarity, e.g., changing "使用額外內容增強提示" to "使用額外內容強化提示詞".
    • Fixes typos and grammatical errors, e.g., "線上工作歷歷史記錄" to "線上工作歷史記錄".
  • Files Affected:
    • account.json: Updates account-related terms and phrases.
    • chat.json: Refines chat interface text and instructions.
    • common.json: Adjusts common UI elements and error messages.
    • ... and 8 other locale files.

This description was created by Ellipsis for 296704f. You can customize this summary. It will automatically update as commits are pushed.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. documentation Improvements or additions to documentation labels Aug 11, 2025
Copy link

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I've reviewed the Traditional Chinese (zh-TW) locale updates and found that most changes improve clarity and consistency. However, there are two typos that need to be fixed before merging.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Aug 12, 2025
Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution!

@mrubens mrubens merged commit 01e417e into RooCodeInc:main Aug 12, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Aug 12, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Aug 12, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 12, 2025
@mrubens
Copy link
Collaborator

mrubens commented Aug 12, 2025

@roomote-agent can you review the changes that @PeterDaveHello (a skilled native speaker) made here and then open a new PR that updates the instructions at .roo/rules-translate/instructions-zh-tw.md with your learnings?

@PeterDaveHello PeterDaveHello deleted the zh-TW branch August 12, 2025 15:44
Copy link

roomote bot commented Aug 12, 2025

Hi @mrubens! I see your request to review the changes made by @PeterDaveHello and update the zh-TW translation instructions. I'm analyzing the improvements now and will create a new PR with updated instructions based on the learnings from this PR. Will update you shortly!

roomote bot pushed a commit that referenced this pull request Aug 12, 2025
- Added comprehensive terminology mapping with notes
- Included new terms learned from native speaker improvements
- Added consistency guidelines for formality and punctuation
- Provided examples of good vs bad translations
- Added review checklist for quality assurance

Based on improvements by @PeterDaveHello in PR #6946
Copy link

roomote bot commented Aug 12, 2025

Hi @mrubens! I've completed the review of @PeterDaveHello's excellent improvements to the zh-TW translations and created a new PR with updated instructions as requested.

📝 New PR: #7001 - docs: update zh-TW translation instructions based on PR #6946 learnings

Summary of Updates

The new instructions now include:

  • 📚 Comprehensive terminology mapping with Traditional Chinese preferences
  • ✨ Consistency guidelines for formality, punctuation, and technical terms
  • 📝 Common patterns for actions, UI elements, and status messages
  • ✅ Real examples from this PR showing good vs bad translations
  • 🔍 A review checklist to ensure quality

These learnings will help future translators maintain the high quality and consistency that @PeterDaveHello demonstrated in this PR. Thank you both for helping improve our localization documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants