Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Aug 12, 2025

This PR adds internationalization support for the Account button title that was previously hardcoded in English.

Changes

  • Replace hardcoded "Account" title with localization key %command.account.title% in src/package.json
  • Add command.account.title translation to all package.nls.*.json files with appropriate translations for each language

Translations Added

  • 🇬🇧 English: Account
  • 🇨🇳 Chinese (Simplified): 账户
  • 🇹🇼 Chinese (Traditional): 帳戶
  • 🇪🇸 Spanish: Cuenta
  • 🇫🇷 French: Compte
  • 🇩🇪 German: Konto
  • 🇮🇹 Italian: Account
  • 🇯🇵 Japanese: アカウント
  • 🇰🇷 Korean: 계정
  • 🇳🇱 Dutch: Account
  • 🇵🇱 Polish: Konto
  • 🇧🇷 Portuguese (Brazil): Conta
  • 🇷🇺 Russian: Аккаунт
  • 🇹🇷 Turkish: Hesap
  • 🇻🇳 Vietnamese: Tài khoản
  • 🇮🇳 Hindi: खाता
  • 🇮🇩 Indonesian: Akun
  • Catalan: Compte

Testing

  • ✅ Type checking passed
  • ✅ Linting passed
  • ✅ All CI checks passed

Related Issue

Fixes #6975

Screenshots

The Account button will now display the appropriate translation based on the selected language in VS Code, consistent with other UI elements.

Acceptance Criteria

  • Account button displays the corresponding text based on the language switched in Roo Code
  • Works like other nearby buttons with proper i18n support
  • No breaking changes introduced

Important

Adds i18n support for the Account button title, replacing hardcoded text with a localization key and translations in multiple languages.

  • Behavior:
    • Replaces hardcoded "Account" title with localization key %command.account.title% in package.json.
    • Adds command.account.title translations to all package.nls.*.json files.
  • Translations:
    • English: Account
    • Chinese (Simplified): 账户
    • Chinese (Traditional): 帳戶
    • Spanish: Cuenta
    • French: Compte
    • German: Konto
    • Italian: Account
    • Japanese: アカウント
    • Korean: 계정
    • Dutch: Account
    • Polish: Konto
    • Portuguese (Brazil): Conta
    • Russian: Аккаунт
    • Turkish: Hesap
    • Vietnamese: Tài khoản
    • Hindi: खाता
    • Indonesian: Akun
    • Catalan: Compte

This description was created by Ellipsis for aceab54. You can customize this summary. It will automatically update as commits are pushed.

- Replace hardcoded "Account" title with localization key in package.json
- Add "command.account.title" translation to all package.nls.*.json files
- Provide appropriate translations for each supported language

Fixes #6975
@roomote roomote bot requested review from cte, jr and mrubens as code owners August 12, 2025 08:51
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 12, 2025
@roomote roomote bot mentioned this pull request Aug 12, 2025
4 tasks
Copy link
Contributor Author

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing my own code is like grading my own homework - suspiciously perfect yet somehow still wrong.

"command.history.title": "Historial",
"command.marketplace.title": "Mercat",
"command.openInEditor.title": "Obrir a l'Editor",
"command.account.title": "Compte",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the key ordering intentional here? I notice appears after in some files but in different positions in others. Would it be better to maintain consistent ordering across all language files for easier maintenance?

"command.history.title": "History",
"command.marketplace.title": "Marketplace",
"command.openInEditor.title": "Open in Editor",
"command.account.title": "Account",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good placement here - right between and . This seems like the logical order that should be maintained across all language files.

"command.history.title": "इतिहास",
"command.marketplace.title": "मार्केटप्लेस",
"command.openInEditor.title": "एडिटर में खोलें",
"command.account.title": "खाता",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Hindi translation 'खाता' looks correct. Have we had native speakers verify these translations, especially for languages with non-Latin scripts?

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Aug 12, 2025
Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Aug 13, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 13, 2025
@mrubens mrubens merged commit 667773b into main Aug 13, 2025
22 checks passed
@mrubens mrubens deleted the feature/i18n-account-button-title branch August 13, 2025 02:59
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Aug 13, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

i18n missing: command.account.title

5 participants