-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix: add i18n support for Account button title #6978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Replace hardcoded "Account" title with localization key in package.json - Add "command.account.title" translation to all package.nls.*.json files - Provide appropriate translations for each supported language Fixes #6975
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing my own code is like grading my own homework - suspiciously perfect yet somehow still wrong.
| "command.history.title": "Historial", | ||
| "command.marketplace.title": "Mercat", | ||
| "command.openInEditor.title": "Obrir a l'Editor", | ||
| "command.account.title": "Compte", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the key ordering intentional here? I notice appears after in some files but in different positions in others. Would it be better to maintain consistent ordering across all language files for easier maintenance?
| "command.history.title": "History", | ||
| "command.marketplace.title": "Marketplace", | ||
| "command.openInEditor.title": "Open in Editor", | ||
| "command.account.title": "Account", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good placement here - right between and . This seems like the logical order that should be maintained across all language files.
| "command.history.title": "इतिहास", | ||
| "command.marketplace.title": "मार्केटप्लेस", | ||
| "command.openInEditor.title": "एडिटर में खोलें", | ||
| "command.account.title": "खाता", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Hindi translation 'खाता' looks correct. Have we had native speakers verify these translations, especially for languages with non-Latin scripts?
daniel-lxs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds internationalization support for the Account button title that was previously hardcoded in English.
Changes
%command.account.title%insrc/package.jsoncommand.account.titletranslation to allpackage.nls.*.jsonfiles with appropriate translations for each languageTranslations Added
Testing
Related Issue
Fixes #6975
Screenshots
The Account button will now display the appropriate translation based on the selected language in VS Code, consistent with other UI elements.
Acceptance Criteria
Important
Adds i18n support for the Account button title, replacing hardcoded text with a localization key and translations in multiple languages.
%command.account.title%inpackage.json.command.account.titletranslations to allpackage.nls.*.jsonfiles.This description was created by
for aceab54. You can customize this summary. It will automatically update as commits are pushed.