-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix: add i18n support for Account button title #6978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,6 +23,7 @@ | |
| "command.history.title": "इतिहास", | ||
| "command.marketplace.title": "मार्केटप्लेस", | ||
| "command.openInEditor.title": "एडिटर में खोलें", | ||
| "command.account.title": "खाता", | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Hindi translation 'खाता' looks correct. Have we had native speakers verify these translations, especially for languages with non-Latin scripts? |
||
| "command.settings.title": "सेटिंग्स", | ||
| "command.documentation.title": "दस्तावेज़ीकरण", | ||
| "configuration.title": "Roo Code", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,6 +11,7 @@ | |
| "command.history.title": "History", | ||
| "command.marketplace.title": "Marketplace", | ||
| "command.openInEditor.title": "Open in Editor", | ||
| "command.account.title": "Account", | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good placement here - right between and . This seems like the logical order that should be maintained across all language files. |
||
| "command.settings.title": "Settings", | ||
| "command.documentation.title": "Documentation", | ||
| "command.openInNewTab.title": "Open In New Tab", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the key ordering intentional here? I notice appears after in some files but in different positions in others. Would it be better to maintain consistent ordering across all language files for easier maintenance?