feat: add "Installed" filter to Roo Marketplace #7007
Conversation
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
- Added installed boolean filter to ViewState interface - Implemented UI checkbox for "Show installed only" filter - Updated filterItems method to filter by installation status - Added translation strings for the new filter - Updated tests to include the new filter property Fixes #7004
dosubot
bot
added
size:L
| payload: { filters: state.filters }, | ||
| }) | ||
| } | ||
| }, [marketplaceInstalledMetadata, state.installedMetadata, state.filters, manager]) |
There was a problem hiding this comment.
Is this useEffect intentional? It seems redundant since the state manager already handles installedMetadata updates through the handleMessage method. This could cause unnecessary re-renders and state updates when the metadata changes.
| <label className="flex items-center gap-2 cursor-pointer"> | ||
| <input | ||
| type="checkbox" | ||
| className="rounded border-vscode-input-border" |
There was a problem hiding this comment.
Could we add proper ARIA labels here for better accessibility? Screen reader users might have difficulty understanding the purpose of this checkbox without proper labeling.
| className="rounded border-vscode-input-border" | |
| <input | |
| type="checkbox" | |
| className="rounded border-vscode-input-border" | |
| checked={state.filters.installed} | |
| aria-label="Show installed items only" | |
| onChange={(e) => |
| } | ||
| installedMetadata?: any // Store installed metadata for filtering |
There was a problem hiding this comment.
Type safety concern: Consider creating a proper TypeScript interface for the installed metadata structure instead of using any. This would improve type safety and make the code more maintainable.
| installedMetadata?: any // Store installed metadata for filtering | |
| installedMetadata?: { | |
| global?: Record<string, any>; | |
| project?: Record<string, any>; | |
| } // Store installed metadata for filtering |
| @@ -65,6 +67,7 @@ | |||
| type: "", | |||
| search: "", | |||
| tags: [], | |||
| installed: false, | |||
| }, | |||
There was a problem hiding this comment.
The installedMetadata field should be initialized in the getDefaultState() method to avoid potential undefined behavior on first load. Consider adding:
| }, | |
| installed: false, | |
| }, | |
| installedMetadata: undefined, |
| if (installed && installedMetadata) { | ||
| const isInstalledGlobally = !!installedMetadata?.global?.[item.id] | ||
| const isInstalledInProject = !!installedMetadata?.project?.[item.id] | ||
| installedMatch = isInstalledGlobally || isInstalledInProject |
There was a problem hiding this comment.
Performance consideration: The installed filter logic checks both global and project metadata for every item when the filter is active. Could we memoize the installed status calculation or compute it once when metadata updates rather than on every filter operation? This would improve performance for large item lists.
|
@roomote-agent Can you please add the missing Translations for this new feature? Currently the QA Roo Code Checks for translation fail. All Other CI/CD Tests seam to work fine. |
hannesrudolph
added
the
Issue/PR - Triage
|
Hi @semidark! I see the issue with the missing translations for the "Installed" filter feature. I'll add the missing translations to all language files right away to fix the failing CI check. |
- Added "filters.installed.label" and "filters.installed.description" keys - Updated all backend marketplace.json files (src/i18n/locales/*/marketplace.json) - Updated all frontend marketplace.json files (webview-ui/src/i18n/locales/*/marketplace.json) - All translation checks now pass successfully
|
@semidark The missing translations have been successfully added! ✅ The check-translations CI job is now passing. I added the required translations for filters.installed.label and filters.installed.description to all 18 supported languages in both backend and frontend marketplace.json files. Total files modified: 35 |
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
This PR adds an "Installed" filter to the Roo Marketplace to help users easily find and manage their installed MCPs and modes.
Changes
installedboolean filter to ViewState interfacefilterItemsmethod to filter by installation statusScreenshots
The new filter appears as a checkbox below the search input:
Testing
installedproperty in filter objectsFixes #7004
Important
Adds an 'Installed' filter to Roo Marketplace, allowing users to filter items by installation status, with updates to UI, state management, translations, and tests.
MarketplaceListViewwith a checkbox to show only installed items.filterItemsinMarketplaceViewStateManagerto filter by installation status.installedboolean toViewStatefilters.MarketplaceViewStateManagerto handleinstalledfilter and metadata.en,es,fr, etc.MarketplaceListView.spec.tsxandMarketplaceViewStateManager.spec.tsto includeinstalledfilter.MarketplaceItemCard.spec.tsxreflects changes in installation status handling.This description was created by
for 07c2478. You can customize this summary. It will automatically update as commits are pushed.