-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: add "Installed" filter to Roo Marketplace #7007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -27,6 +27,17 @@ export function MarketplaceListView({ stateManager, allTags, filteredTags, filte | |||||||||||||||
const allItems = state.displayItems || [] | ||||||||||||||||
const organizationMcps = state.displayOrganizationMcps || [] | ||||||||||||||||
|
||||||||||||||||
// Update state manager with installed metadata when it changes | ||||||||||||||||
React.useEffect(() => { | ||||||||||||||||
if (marketplaceInstalledMetadata && state.installedMetadata !== marketplaceInstalledMetadata) { | ||||||||||||||||
// Update the state manager's installed metadata | ||||||||||||||||
manager.transition({ | ||||||||||||||||
type: "UPDATE_FILTERS", | ||||||||||||||||
payload: { filters: state.filters }, | ||||||||||||||||
}) | ||||||||||||||||
} | ||||||||||||||||
}, [marketplaceInstalledMetadata, state.installedMetadata, state.filters, manager]) | ||||||||||||||||
|
||||||||||||||||
// Filter items by type if specified | ||||||||||||||||
const items = filterByType ? allItems.filter((item) => item.type === filterByType) : allItems | ||||||||||||||||
const orgMcps = filterByType === "mcp" ? organizationMcps : [] | ||||||||||||||||
|
@@ -55,6 +66,28 @@ export function MarketplaceListView({ stateManager, allTags, filteredTags, filte | |||||||||||||||
} | ||||||||||||||||
/> | ||||||||||||||||
</div> | ||||||||||||||||
{/* Installed filter toggle */} | ||||||||||||||||
<div className="mt-2 flex items-center gap-2"> | ||||||||||||||||
<label className="flex items-center gap-2 cursor-pointer"> | ||||||||||||||||
<input | ||||||||||||||||
type="checkbox" | ||||||||||||||||
className="rounded border-vscode-input-border" | ||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we add proper ARIA labels here for better accessibility? Screen reader users might have difficulty understanding the purpose of this checkbox without proper labeling.
Suggested change
|
||||||||||||||||
checked={state.filters.installed} | ||||||||||||||||
onChange={(e) => | ||||||||||||||||
manager.transition({ | ||||||||||||||||
type: "UPDATE_FILTERS", | ||||||||||||||||
payload: { filters: { installed: e.target.checked } }, | ||||||||||||||||
}) | ||||||||||||||||
} | ||||||||||||||||
/> | ||||||||||||||||
<span className="text-sm">{t("marketplace:filters.installed.label")}</span> | ||||||||||||||||
</label> | ||||||||||||||||
{state.filters.installed && ( | ||||||||||||||||
<span className="text-xs text-vscode-descriptionForeground"> | ||||||||||||||||
({t("marketplace:filters.installed.description")}) | ||||||||||||||||
</span> | ||||||||||||||||
)} | ||||||||||||||||
</div> | ||||||||||||||||
{allTags.length > 0 && ( | ||||||||||||||||
<div className="mt-2"> | ||||||||||||||||
<div className="flex items-center justify-between mb-1"> | ||||||||||||||||
|
@@ -187,7 +220,7 @@ export function MarketplaceListView({ stateManager, allTags, filteredTags, filte | |||||||||||||||
onClick={() => | ||||||||||||||||
manager.transition({ | ||||||||||||||||
type: "UPDATE_FILTERS", | ||||||||||||||||
payload: { filters: { search: "", type: "", tags: [] } }, | ||||||||||||||||
payload: { filters: { search: "", type: "", tags: [], installed: false } }, | ||||||||||||||||
}) | ||||||||||||||||
} | ||||||||||||||||
className="mt-4 bg-vscode-button-secondaryBackground text-vscode-button-secondaryForeground hover:bg-vscode-button-secondaryHoverBackground transition-colors"> | ||||||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this useEffect intentional? It seems redundant since the state manager already handles installedMetadata updates through the handleMessage method. This could cause unnecessary re-renders and state updates when the metadata changes.