Skip to content

Conversation

@dtrugman
Copy link
Contributor

@dtrugman dtrugman commented Aug 24, 2025

Related GitHub Issue

Closes: #7377

Roo Code Task Context (Optional)

Description

Fix the model listing URL for Requesty

Test Procedure

Check that the model listing URL ends with /v1/models, not just /models.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

N/A

Documentation Updates

N/A

Additional Notes

Please help us merge this into nightly before the current nightly hits prod.


Important

Fixes the model listing URL in getRequestyModels to use /v1/models endpoint.

  • Behavior:
    • Fixes the model listing URL in getRequestyModels function in requesty.ts to use /v1/models instead of /models.
  • Misc:
    • Adds a changeset file spotty-queens-crash.md for versioning.

This description was created by Ellipsis for aca6592. You can customize this summary. It will automatically update as commits are pushed.

@dtrugman dtrugman requested review from cte, jr and mrubens as code owners August 24, 2025 23:59
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Aug 24, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Aug 25, 2025
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! The fix correctly addresses the issue described in #7377. I've reviewed the changes and have one suggestion for improvement.


const resolvedBaseUrl = toRequestyServiceUrl(baseUrl)
const modelsUrl = new URL("models", resolvedBaseUrl)
const modelsUrl = new URL("v1/models", resolvedBaseUrl)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good! Changing to correctly ensures the proper URL construction.

However, I noticed there are no dedicated unit tests for the function. Would it be beneficial to add test coverage for this URL construction logic to prevent regression? This could help ensure the fix continues to work correctly with various base URL formats.


const resolvedBaseUrl = toRequestyServiceUrl(baseUrl)
const modelsUrl = new URL("models", resolvedBaseUrl)
const modelsUrl = new URL("v1/models", resolvedBaseUrl)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good! Changing to "v1/models" correctly ensures the proper URL construction.

However, I noticed there are no dedicated unit tests for the getRequestyModels function. Would it be beneficial to add test coverage for this URL construction logic to prevent regression? This could help ensure the fix continues to work correctly with various base URL formats.

Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Maybe we or @roomote-agent can open a new PR with a test as a follow-up.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 25, 2025
@mrubens mrubens merged commit 0c481a3 into RooCodeInc:main Aug 25, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Aug 25, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Requesty model fetching broken

3 participants