Skip to content

Fix requesty model listing #7378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2025
Merged

Fix requesty model listing #7378

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aca6592
Fix requesty model listing
dtrugman Aug 24, 2025
d109743
Delete .changeset/spotty-queens-crash.md
mrubens Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/api/providers/fetchers/requesty.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export async function getRequestyModels(baseUrl?: string, apiKey?: string): Prom
}

const resolvedBaseUrl = toRequestyServiceUrl(baseUrl)
const modelsUrl = new URL("models", resolvedBaseUrl)
const modelsUrl = new URL("v1/models", resolvedBaseUrl)
Copy link
Contributor

@roomote roomote bot Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good! Changing to correctly ensures the proper URL construction.

However, I noticed there are no dedicated unit tests for the function. Would it be beneficial to add test coverage for this URL construction logic to prevent regression? This could help ensure the fix continues to work correctly with various base URL formats.

Copy link
Contributor

@roomote roomote bot Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good! Changing to "v1/models" correctly ensures the proper URL construction.

However, I noticed there are no dedicated unit tests for the getRequestyModels function. Would it be beneficial to add test coverage for this URL construction logic to prevent regression? This could help ensure the fix continues to work correctly with various base URL formats.


const response = await axios.get(modelsUrl.toString(), { headers })
const rawModels = response.data.data
Expand Down
Loading