fix: add todos parameter to new_task tool usage in issue-fixer mode #7391
Conversation
- Added required todos parameter to new_task tool in translation step - Included comprehensive todo list for translation tasks - Updated best practices to remind about including todos when using new_task - Ensures compatibility with current new_task tool API requirements
dosubot
bot
added
size:XS
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the issue-fixer mode configuration to properly use the new_task tool by adding the required todos parameter that was previously missing. This ensures the tool works correctly when delegating translation tasks.
- Adds missing
todosparameter tonew_tasktool usage in workflow configuration - Adds a best practice reminder to always include comprehensive todos when using
new_task
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.roo/rules-issue-fixer/1_Workflow.xml |
Adds required todos parameter with 5-item checklist for translation tasks |
.roo/rules-issue-fixer/2_best_practices.xml |
Adds best practice to include comprehensive todos when using new_task |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| [ ] Identify all user-facing strings that need translation | ||
| [ ] Update i18n JSON files for all supported languages | ||
| [ ] Translate any markdown documentation files | ||
| [ ] Verify translations maintain consistency with existing terminology | ||
| [ ] Test translations in the application context |
There was a problem hiding this comment.
The todos checklist items are missing the standard markdown checkbox format. Consider using - [ ] instead of [ ] to ensure proper markdown formatting consistency.
| [ ] Identify all user-facing strings that need translation | |
| [ ] Update i18n JSON files for all supported languages | |
| [ ] Translate any markdown documentation files | |
| [ ] Verify translations maintain consistency with existing terminology | |
| [ ] Test translations in the application context | |
| - [ ] Identify all user-facing strings that need translation | |
| - [ ] Update i18n JSON files for all supported languages | |
| - [ ] Translate any markdown documentation files | |
| - [ ] Verify translations maintain consistency with existing terminology | |
| - [ ] Test translations in the application context |
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for your contribution! I've reviewed the changes and they correctly add the required todos parameter to the new_task tool usage in the issue-fixer mode. The implementation looks good overall, with just one suggestion for consistency across the codebase.
| [ ] Update i18n JSON files for all supported languages | ||
| [ ] Translate any markdown documentation files | ||
| [ ] Verify translations maintain consistency with existing terminology | ||
| [ ] Test translations in the application context |
There was a problem hiding this comment.
Good addition! The todo list is well-structured and covers the essential translation tasks. The items are actionable and follow a logical sequence.
For future enhancements, you might consider adding:
[ ] Check for any hardcoded strings that need extraction[ ] Validate translations against glossary/terminology guide
But the current list is sufficient for the immediate need.
| - Check for accessibility issues (for UI changes) | ||
| - Delegate translation tasks to translate mode when implementing user-facing changes | ||
| - Always check for hard-coded strings and internationalization needs | ||
| - When using new_task to delegate work, always include a comprehensive todos list |
There was a problem hiding this comment.
Excellent addition to the best practices! This will help ensure future uses of the new_task tool include the todos parameter.
Is this intentional that similar new_task usages in other mode rules (like pr-fixer) don't have the todos parameter? I found instances in:
.roo/rules-pr-fixer/3_common_patterns.xml(lines 41-44).roo/rules-pr-fixer/5_examples.xml(lines 126-139, 227-230)
These could be updated for consistency, though they could be addressed in a separate PR if you prefer.
hannesrudolph
added
PR - Needs Review
and removed
Issue/PR - Triage
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
Description
This PR updates the issue-fixer mode rules to include the required
todosparameter when using thenew_tasktool, ensuring compatibility with the current tool API.Changes Made
1. Updated
.roo/rules-issue-fixer/1_Workflow.xml(Step 7)todosparameter to thenew_tasktool usage in the translation step2. Updated
.roo/rules-issue-fixer/2_best_practices.xmlnew_tasktool will remember to include the todos parameterWhy This Change Is Needed
The
new_tasktool requires three parameters:mode: The mode to switch tomessage: The initial instructions for the tasktodos: A markdown checklist of tasks to complete (this was missing)Without the
todosparameter, thenew_tasktool would fail when the issue-fixer mode tries to delegate translation work.Testing
Impact
This is a documentation/configuration change only. It ensures the issue-fixer mode correctly uses the
new_tasktool when delegating translation tasks to the translate mode.Important
Adds
todosparameter tonew_tasktool in issue-fixer mode and updates best practices to ensure API compatibility.todosparameter tonew_tasktool in.roo/rules-issue-fixer/1_Workflow.xmlto ensure compatibility with the tool API..roo/rules-issue-fixer/2_best_practices.xmlto include a guideline for always including a comprehensive todos list when usingnew_task.This description was created by
for df42890. You can customize this summary. It will automatically update as commits are pushed.