Skip to content

fix: add todos parameter to new_task tool usage in issue-fixer mode #7391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2025
Merged

fix: add todos parameter to new_task tool usage in issue-fixer mode #7391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .roo/rules-issue-fixer/1_Workflow.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,13 @@
- [Note any technical terms or constraints]

Please ensure all translations maintain consistency with existing terminology and follow the project's localization guidelines.</message>
<todos>
[ ] Identify all user-facing strings that need translation
[ ] Update i18n JSON files for all supported languages
[ ] Translate any markdown documentation files
[ ] Verify translations maintain consistency with existing terminology
[ ] Test translations in the application context
Comment on lines +277 to +281
Copy link

Copilot AI Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The todos checklist items are missing the standard markdown checkbox format. Consider using - [ ] instead of [ ] to ensure proper markdown formatting consistency.

Suggested change
[ ] Identify all user-facing strings that need translation
[ ] Update i18n JSON files for all supported languages
[ ] Translate any markdown documentation files
[ ] Verify translations maintain consistency with existing terminology
[ ] Test translations in the application context
- [ ] Identify all user-facing strings that need translation
- [ ] Update i18n JSON files for all supported languages
- [ ] Translate any markdown documentation files
- [ ] Verify translations maintain consistency with existing terminology
- [ ] Test translations in the application context

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@roomote roomote bot Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition! The todo list is well-structured and covers the essential translation tasks. The items are actionable and follow a logical sequence.

For future enhancements, you might consider adding:

  • [ ] Check for any hardcoded strings that need extraction
  • [ ] Validate translations against glossary/terminology guide

But the current list is sufficient for the immediate need.

</todos>
</new_task>

Wait for the translation task to complete before proceeding to testing.
Expand Down
1 change: 1 addition & 0 deletions .roo/rules-issue-fixer/2_best_practices.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,6 @@
- Check for accessibility issues (for UI changes)
- Delegate translation tasks to translate mode when implementing user-facing changes
- Always check for hard-coded strings and internationalization needs
- When using new_task to delegate work, always include a comprehensive todos list
Copy link
Contributor

@roomote roomote bot Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent addition to the best practices! This will help ensure future uses of the new_task tool include the todos parameter.

Is this intentional that similar new_task usages in other mode rules (like pr-fixer) don't have the todos parameter? I found instances in:

  • .roo/rules-pr-fixer/3_common_patterns.xml (lines 41-44)
  • .roo/rules-pr-fixer/5_examples.xml (lines 126-139, 227-230)

These could be updated for consistency, though they could be addressed in a separate PR if you prefer.

- Wait for translation completion before proceeding to final testing
</best_practices>
Loading