Mark code-workspace files as protected #7403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
dosubot
bot
added
size:S
jr
approved these changes
Aug 26, 2025
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| ".rooprotected", // For future use | ||
| "AGENTS.md", | ||
| "AGENT.md", // Alternative singular form for compatibility | ||
| "AGENT.md", |
Contributor
There was a problem hiding this comment.
The comment "Alternative singular form for compatibility" was removed from the AGENT.md line. Was this intentional? If not, you might want to restore it:
| it("should protect .code-workspace files", () => { | ||
| expect(controller.isWriteProtected("myproject.code-workspace")).toBe(true) | ||
| expect(controller.isWriteProtected("pentest.code-workspace")).toBe(true) | ||
| expect(controller.isWriteProtected(".code-workspace")).toBe(true) |
Contributor
There was a problem hiding this comment.
Good comprehensive test coverage! I notice you're testing (without a prefix). Is this a valid workspace filename that VSCode actually uses? If not, we might want to remove this test case to keep tests focused on real-world scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit to @thelicato for reporting this
Important
Add
*.code-workspaceto protected patterns inRooProtectedControllerand update tests accordingly.*.code-workspaceto protected patterns inRooProtectedControllerto prevent code execution.RooProtectedController.spec.tsto verify*.code-workspacefiles are write-protected.This description was created by
for 32b5636. You can customize this summary. It will automatically update as commits are pushed.