Skip to content

Mark code-workspace files as protected #7403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2025
Merged

Mark code-workspace files as protected #7403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32b5636
Mark code-workspace files as protected
mrubens Aug 26, 2025
a4a68ce
Refactor protection rules in RooProtectedController
mrubens Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/core/protect/RooProtectedController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,10 @@ export class RooProtectedController {
".clinerules*",
".roo/**",
".vscode/**",
"*.code-workspace",
".rooprotected", // For future use
"AGENTS.md",
"AGENT.md", // Alternative singular form for compatibility
"AGENT.md",
Copy link
Contributor

@roomote roomote bot Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment "Alternative singular form for compatibility" was removed from the AGENT.md line. Was this intentional? If not, you might want to restore it:

]

constructor(cwd: string) {
Expand Down
8 changes: 8 additions & 0 deletions src/core/protect/__tests__/RooProtectedController.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,13 @@ describe("RooProtectedController", () => {
expect(controller.isWriteProtected(".vscode/tasks.json")).toBe(true)
})

it("should protect .code-workspace files", () => {
expect(controller.isWriteProtected("myproject.code-workspace")).toBe(true)
expect(controller.isWriteProtected("pentest.code-workspace")).toBe(true)
expect(controller.isWriteProtected(".code-workspace")).toBe(true)
Copy link
Contributor

@roomote roomote bot Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good comprehensive test coverage! I notice you're testing (without a prefix). Is this a valid workspace filename that VSCode actually uses? If not, we might want to remove this test case to keep tests focused on real-world scenarios.

expect(controller.isWriteProtected("folder/workspace.code-workspace")).toBe(true)
})

it("should protect AGENTS.md file", () => {
expect(controller.isWriteProtected("AGENTS.md")).toBe(true)
})
Expand Down Expand Up @@ -149,6 +156,7 @@ describe("RooProtectedController", () => {
".clinerules*",
".roo/**",
".vscode/**",
"*.code-workspace",
".rooprotected",
"AGENTS.md",
"AGENT.md",
Expand Down
Loading