fix: restore checkpoint visibility in UI #7787
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed suppressMessage flag from true to false when creating checkpoints for user messages - This ensures checkpoints are visible in the UI so users can restore their code when needed - Fixes issue where checkpoint list was not appearing below API requests Fixes #7786
dosubot
bot
added
size:XS
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| // Create a checkpoint whenever the user sends a message. | ||
| // Use allowEmpty=true to ensure a checkpoint is recorded even if there are no file changes. | ||
| // Suppress the checkpoint_saved chat row for this particular checkpoint to keep the timeline clean. | ||
| // Do not suppress the checkpoint_saved chat row so users can see and restore checkpoints. |
Contributor
Author
There was a problem hiding this comment.
Good catch on updating the comment to match the new behavior. This makes the intent clear for future maintainers.
| // Do not suppress the checkpoint_saved chat row so users can see and restore checkpoints. | ||
| if (askResponse === "messageResponse") { | ||
| void this.checkpointSave(false, true) | ||
| void this.checkpointSave(false, false) |
Contributor
Author
There was a problem hiding this comment.
This is the correct fix. Changing from true to false ensures checkpoint messages are visible in the UI, which directly addresses the issue reported in #7786.
However, would it be worth adding a test case specifically for this behavior? Something that verifies checkpointSave is called with suppressMessage=false when handling messageResponse. This would help prevent regression in the future.
hannesrudolph
added
the
Issue/PR - Triage
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
Member
|
Closing for now, issue needs more info #7786 (comment) |
github-project-automation
bot
moved this from PR [Needs Prelim Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue where checkpoints were not appearing in the UI, preventing users from restoring their code when needed.
Problem
Solution
Changed the
suppressMessageflag fromtruetofalsewhen creating checkpoints for user messages. This ensures checkpoints are visible in the UI while maintaining all checkpoint functionality.Changes
src/core/task/Task.tsline 897 to not suppress checkpoint messagesTesting
checkpoint.test.ts)CheckpointRestoreDialog.spec.tsx)Related Issue
Fixes #7786
Screenshots
The checkpoint list will now be visible below API requests as expected.
Review Notes
This is a minimal change that only affects the visibility of checkpoint messages in the UI. The underlying checkpoint functionality remains unchanged.
Important
Fixes checkpoint visibility in UI by setting
suppressMessagetofalseinTask.ts, allowing users to see and restore checkpoints.suppressMessagetofalseinhandleWebviewAskResponse()inTask.ts.checkpoint.test.ts).CheckpointRestoreDialog.spec.tsx).This description was created by
for e642f9b. You can customize this summary. It will automatically update as commits are pushed.