-
Notifications
You must be signed in to change notification settings - Fork 2.5k
fix: restore checkpoint visibility in UI #7787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -892,9 +892,9 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike { | |
|
|
||
| // Create a checkpoint whenever the user sends a message. | ||
| // Use allowEmpty=true to ensure a checkpoint is recorded even if there are no file changes. | ||
| // Suppress the checkpoint_saved chat row for this particular checkpoint to keep the timeline clean. | ||
| // Do not suppress the checkpoint_saved chat row so users can see and restore checkpoints. | ||
| if (askResponse === "messageResponse") { | ||
| void this.checkpointSave(false, true) | ||
| void this.checkpointSave(false, false) | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the correct fix. Changing from However, would it be worth adding a test case specifically for this behavior? Something that verifies checkpointSave is called with suppressMessage=false when handling messageResponse. This would help prevent regression in the future. |
||
| } | ||
|
|
||
| // Mark the last follow-up question as answered | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch on updating the comment to match the new behavior. This makes the intent clear for future maintainers.