fix: prevent chat input from being cleared when queueing messages #7862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a message is queued while sending is disabled, the input field should not be cleared to preserve any new text the user is typing. Only the selected images are cleared since they were included with the queued message. Fixes #7861
dosubot
bot
added
size:XS
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| console.log("queueMessage", text, images) | ||
| vscode.postMessage({ type: "queueMessage", text, images }) | ||
| setInputValue("") | ||
| // Don't clear the input when queueing - user may be typing a new message |
Contributor
Author
There was a problem hiding this comment.
Good fix for preserving user input when queueing messages. However, I noticed that in other parts of this file (lines 702 and 757 in handlePrimaryButtonClick and handleSecondaryButtonClick), the input is still cleared when handling button clicks. Is this intentional? Should we consider making the input preservation behavior consistent across all queueing scenarios, or are those different use cases where clearing is desired?
| setInputValue("") | ||
| // Don't clear the input when queueing - user may be typing a new message | ||
| // Only clear the images since they were queued with this message | ||
| setSelectedImages([]) |
Contributor
Author
There was a problem hiding this comment.
Would it be worth adding unit tests for this queueing behavior? I noticed there are no tests for the ChatView component currently. Tests would help prevent regressions and document the expected behavior for future maintainers.
hannesrudolph
added
the
Issue/PR - Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the chat input field was being cleared when a message was queued while sending was disabled.
Problem
When a queued message is sent, any unsent text in the chatbox is wiped. This affects users who have messages queued (e.g., while approval is pending) and then type new text before the queue processes.
Solution
Modified the
handleSendMessagefunction inChatView.tsxto not clear the input value when queueing messages. Only the selected images are cleared since they are associated with the queued message.Changes
setInputValue("")when queueing messagesTesting
Fixes #7861
Important
Fixes chat input clearing issue in
ChatView.tsxby retaining input value when queueing messages.ChatView.tsxwhere chat input was cleared when queueing messages.handleSendMessageto retain input value when queueing, only clearing selected images.setInputValue("")fromhandleSendMessage.This description was created by
for 8c4a97d. You can customize this summary. It will automatically update as commits are pushed.