Skip to content

fix: preserve chat input when processing queued messages #7866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: preserve chat input when processing queued messages #7866

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion webview-ui/src/components/chat/ChatView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,8 @@ const ChatViewComponent: React.ForwardRefRenderFunction<ChatViewRef, ChatViewPro
try {
console.log("queueMessage", text, images)
vscode.postMessage({ type: "queueMessage", text, images })
setInputValue("")
// Don't clear the input when queueing - user may be typing more
Copy link
Contributor Author

@roomote roomote bot Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix! The comment clearly explains why we're not clearing the input when queueing. However, consider adding a test specifically for this queue behavior to prevent regression. The test should verify:

  • Input text is preserved when queueing
  • Input is properly cleared when the message is actually sent
  • Selected images are cleared immediately (current behavior)

// The input will be cleared when the message is actually sent
setSelectedImages([])
Copy link
Contributor Author

@roomote roomote bot Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is clearing images immediately intentional? Users might want to continue adding images while waiting, similar to how text is now preserved. This could be a nice enhancement for consistency, though the current behavior might be by design to show images are attached to the queued message.

} catch (error) {
console.error(
Expand Down
Loading