fix: preserve chat input when processing queued messages #7866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified handleSendMessage to not clear input value when queueing - Only clear selected images when queueing a message - Input will be cleared when message is actually sent, not when queued - Fixes #7861 where unsent text was lost when queued messages were processed
dosubot
bot
added
size:XS
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| console.log("queueMessage", text, images) | ||
| vscode.postMessage({ type: "queueMessage", text, images }) | ||
| setInputValue("") | ||
| // Don't clear the input when queueing - user may be typing more |
Contributor
Author
There was a problem hiding this comment.
Good fix! The comment clearly explains why we're not clearing the input when queueing. However, consider adding a test specifically for this queue behavior to prevent regression. The test should verify:
- Input text is preserved when queueing
- Input is properly cleared when the message is actually sent
- Selected images are cleared immediately (current behavior)
| setInputValue("") | ||
| // Don't clear the input when queueing - user may be typing more | ||
| // The input will be cleared when the message is actually sent | ||
| setSelectedImages([]) |
Contributor
Author
There was a problem hiding this comment.
Is clearing images immediately intentional? Users might want to continue adding images while waiting, similar to how text is now preserved. This could be a nice enhancement for consistency, though the current behavior might be by design to show images are attached to the queued message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #7861 where the chat input was being cleared when a queued message was sent, causing users to lose any text they had typed while waiting for the queue to process.
Problem
When a message is queued (e.g., while waiting for approval), the chat input is immediately cleared. If the user types new text before the queue processes, that text is lost when the queued message is sent.
Solution
Modified the
handleSendMessagefunction inChatView.tsxto preserve the input value when queueing messages:setInputValue("")when queueing a messageTesting
Related Issue
Fixes #7861
Type of Change
Checklist
Important
Fixes issue #7861 by preserving chat input in
ChatView.tsxwhen queueing messages, ensuring input is only cleared upon message sending.handleSendMessageinChatView.tsxto preserve chat input when queueing messages.setInputValue("")when queueing, ensuring input is only cleared when the message is sent.This description was created by
for e84008a. You can customize this summary. It will automatically update as commits are pushed.