-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat: Reposition History button from overflow to main toolbar #7888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Reposition History button from overflow to main toolbar #7888
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! The changes successfully address issue #7887 by moving the History button to the main toolbar, reducing the interaction overhead from two clicks to one. The implementation is clean, consistent across both view contexts, and all tests are passing. I've left a couple of minor suggestions for consideration.
| "command": "roo-cline.historyButtonClicked", | ||
| "group": "overflow@1", | ||
| "command": "roo-cline.cloudButtonClicked", | ||
| "group": "navigation@5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repositioning looks good and maintains proper sequential ordering. However, I'm curious - is having 5 navigation items within VSCode's recommended limits for toolbar items? Some users with smaller screens might find the toolbar a bit crowded. Have you tested this on different screen sizes?
| "command": "roo-cline.historyButtonClicked", | ||
| "group": "overflow@1", | ||
| "command": "roo-cline.cloudButtonClicked", | ||
| "group": "navigation@5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice the cloud button is now at position 5. Given that History might be used more frequently than Cloud features, would it make sense to consider the usage frequency when ordering these buttons? Perhaps Cloud could remain in the overflow menu if it's less commonly used? Just a thought for optimizing the toolbar real estate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing, this change was on purpose, please read the parent issue
Changes
Modified menu contributions in src/package.json:
Testing
Technical Details
Line modifications in src/package.json:
Fixes #7887
Important
Reposition
historyButtonClickedto main toolbar insrc/package.json, adjusting other navigation items accordingly, with all tests passing.historyButtonClickedfromoverflow@1tonavigation@2insrc/package.json.marketplaceButtonClicked,settingsButtonClicked, andcloudButtonClickedpositions tonavigation@3,navigation@4, andnavigation@5respectively.view/titleandeditor/titlecontexts.This description was created by
for c2c136a. You can customize this summary. It will automatically update as commits are pushed.