Skip to content

Conversation

@victoraranda
Copy link

@victoraranda victoraranda commented Sep 11, 2025

Changes

Modified menu contributions in src/package.json:

  • Repositioned historyButtonClicked from overflow@1 to navigation@2
  • Adjusted navigation positions: marketplace@3, settings@4, cloud@5
  • Applied to both view/title and editor/title contexts

Testing

  • Backend tests: 290 files, 3778 passing
  • UI tests: 86 files, 1032 passing
  • Type checking: passing
  • Linting: passing

Technical Details

Line modifications in src/package.json:

  • Lines 227, 269: historyButtonClicked group change
  • Lines 228-230, 270-272: navigation item position adjustments

Fixes #7887


Important

Reposition historyButtonClicked to main toolbar in src/package.json, adjusting other navigation items accordingly, with all tests passing.

  • Behavior:
    • Reposition historyButtonClicked from overflow@1 to navigation@2 in src/package.json.
    • Adjust marketplaceButtonClicked, settingsButtonClicked, and cloudButtonClicked positions to navigation@3, navigation@4, and navigation@5 respectively.
    • Changes apply to both view/title and editor/title contexts.
  • Testing:
    • Backend tests: 3778 passing.
    • UI tests: 1032 passing.
    • Type checking and linting: passing.

This description was created by Ellipsis for c2c136a. You can customize this summary. It will automatically update as commits are pushed.

- Repositioned History button from overflow menu to navigation@2
- Shifted existing navigation items: Marketplace to @3, Settings to @4, Cloud to @5
- Applied changes consistently to both sidebar and editor views
- Improves UX by providing quick access to frequently-used History feature
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. UI/UX UI/UX related or focused labels Sep 11, 2025
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! The changes successfully address issue #7887 by moving the History button to the main toolbar, reducing the interaction overhead from two clicks to one. The implementation is clean, consistent across both view contexts, and all tests are passing. I've left a couple of minor suggestions for consideration.

"command": "roo-cline.historyButtonClicked",
"group": "overflow@1",
"command": "roo-cline.cloudButtonClicked",
"group": "navigation@5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repositioning looks good and maintains proper sequential ordering. However, I'm curious - is having 5 navigation items within VSCode's recommended limits for toolbar items? Some users with smaller screens might find the toolbar a bit crowded. Have you tested this on different screen sizes?

"command": "roo-cline.historyButtonClicked",
"group": "overflow@1",
"command": "roo-cline.cloudButtonClicked",
"group": "navigation@5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice the cloud button is now at position 5. Given that History might be used more frequently than Cloud features, would it make sense to consider the usage frequency when ordering these buttons? Perhaps Cloud could remain in the overflow menu if it's less commonly used? Just a thought for optimizing the toolbar real estate.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Sep 11, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Sep 11, 2025
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Sep 11, 2025
Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing, this change was on purpose, please read the parent issue

@daniel-lxs daniel-lxs closed this Sep 11, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Sep 11, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Prelim Review] to Done in Roo Code Roadmap Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR - Needs Preliminary Review size:S This PR changes 10-29 lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Reposition History button from overflow to main toolbar

3 participants