Skip to content

feat: Reposition History button from overflow to main toolbar #7888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat: Reposition History button from overflow to main toolbar #7888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,23 +224,23 @@
"when": "view == roo-cline.SidebarProvider"
},
{
"command": "roo-cline.marketplaceButtonClicked",
"command": "roo-cline.historyButtonClicked",
"group": "navigation@2",
"when": "view == roo-cline.SidebarProvider"
},
{
"command": "roo-cline.settingsButtonClicked",
"command": "roo-cline.marketplaceButtonClicked",
"group": "navigation@3",
"when": "view == roo-cline.SidebarProvider"
},
{
"command": "roo-cline.cloudButtonClicked",
"command": "roo-cline.settingsButtonClicked",
"group": "navigation@4",
"when": "view == roo-cline.SidebarProvider"
},
{
"command": "roo-cline.historyButtonClicked",
"group": "overflow@1",
"command": "roo-cline.cloudButtonClicked",
"group": "navigation@5",
Copy link
Contributor

@roomote roomote bot Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repositioning looks good and maintains proper sequential ordering. However, I'm curious - is having 5 navigation items within VSCode's recommended limits for toolbar items? Some users with smaller screens might find the toolbar a bit crowded. Have you tested this on different screen sizes?

"when": "view == roo-cline.SidebarProvider"
},
{
Expand All @@ -266,23 +266,23 @@
"when": "activeWebviewPanelId == roo-cline.TabPanelProvider"
},
{
"command": "roo-cline.marketplaceButtonClicked",
"command": "roo-cline.historyButtonClicked",
"group": "navigation@2",
"when": "activeWebviewPanelId == roo-cline.TabPanelProvider"
},
{
"command": "roo-cline.settingsButtonClicked",
"command": "roo-cline.marketplaceButtonClicked",
"group": "navigation@3",
"when": "activeWebviewPanelId == roo-cline.TabPanelProvider"
},
{
"command": "roo-cline.cloudButtonClicked",
"command": "roo-cline.settingsButtonClicked",
"group": "navigation@4",
"when": "activeWebviewPanelId == roo-cline.TabPanelProvider"
},
{
"command": "roo-cline.historyButtonClicked",
"group": "overflow@1",
"command": "roo-cline.cloudButtonClicked",
"group": "navigation@5",
Copy link
Contributor

@roomote roomote bot Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice the cloud button is now at position 5. Given that History might be used more frequently than Cloud features, would it make sense to consider the usage frequency when ordering these buttons? Perhaps Cloud could remain in the overflow menu if it's less commonly used? Just a thought for optimizing the toolbar real estate.

"when": "activeWebviewPanelId == roo-cline.TabPanelProvider"
},
{
Expand Down
Loading