feat: Reposition History button from overflow to main toolbar #7889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move historyButtonClicked from overflow@1 to navigation@2 - Shift navigation items: marketplace@3, settings@4, cloud@5 - Update overflow items indices accordingly - Apply changes to both view/title and editor/title menus Fixes #7887
dosubot
bot
added
size:M
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| "command": "roo-cline.historyButtonClicked", | ||
| "group": "overflow@1", | ||
| "command": "roo-cline.cloudButtonClicked", | ||
| "group": "navigation@5", |
Contributor
Author
There was a problem hiding this comment.
Is having 5 buttons in the main toolbar intentional? VSCode typically shows only 3-4 navigation items before collapsing to overflow on smaller screens. The Cloud button at position @5 might get hidden on some displays. Should we consider which buttons are most essential for the main toolbar?
| "command": "roo-cline.historyButtonClicked", | ||
| "group": "overflow@1", | ||
| "command": "roo-cline.cloudButtonClicked", | ||
| "group": "navigation@5", |
Contributor
Author
There was a problem hiding this comment.
The menu configuration is duplicated between view/title (lines 220-260) and editor/title (lines 262-302). Could we explore extracting this to a shared configuration to reduce duplication and make future maintenance easier? Perhaps a helper function or constant that both sections could reference?
hannesrudolph
added
the
Issue/PR - Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR attempts to address Issue #7887 by repositioning the History button from the overflow menu to the main toolbar, reducing the interaction overhead from two clicks to one.
Changes
historyButtonClickedfromoverflow@1tonavigation@2in bothview/titleandeditor/titlemenusnavigation@2→navigation@3navigation@3→navigation@4navigation@4→navigation@5Testing
✅ Backend tests: 290 files, 3778 tests passing
✅ UI tests: 86 files, 1032 tests passing
✅ All linting and type checks passing
Related Issue
Fixes #7887
Feedback and guidance are welcome!
Important
Repositioned the History button to the main toolbar in
view/titleandeditor/titlemenus, adjusting other navigation items accordingly.historyButtonClickedfromoverflow@1tonavigation@2inview/titleandeditor/titlemenus.marketplaceButtonClicked,settingsButtonClicked, andcloudButtonClickedtonavigation@3,navigation@4, andnavigation@5respectively.promptsButtonClicked,mcpButtonClicked, andpopoutButtonClickedtooverflow@1,overflow@2, andoverflow@3.This description was created by
for 50d039f. You can customize this summary. It will automatically update as commits are pushed.