Skip to content

fix: add GLM 4.5 Air models to OpenRouter reasoning budget models #8314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: add GLM 4.5 Air models to OpenRouter reasoning budget models #8314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61fa160
feat: add GLM 4.5 Air models to OpenRouter reasoning budget models
roomote Sep 25, 2025
d381fde
test: add GLM 4.5 Air models to excluded list in OpenRouter tests
roomote Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/types/src/providers/openrouter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ export const OPEN_ROUTER_REASONING_BUDGET_MODELS = new Set([
"google/gemini-2.5-flash-preview-05-20",
"google/gemini-2.5-flash",
"google/gemini-2.5-flash-lite-preview-06-17",
"z-ai/glm-4.5-air",
"z-ai/glm-4.5-air:free",
Copy link
Contributor Author

@roomote roomote bot Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: Consider adding a short note (or link to OpenRouter docs/changelog) explaining that GLM 4.5 Air supports the reasoning parameter and why we include it here. This helps future readers verify intent without re-checking the API.

// Also include the models that require the reasoning budget to be enabled
// even though `OPEN_ROUTER_REQUIRED_REASONING_BUDGET_MODELS` takes precedence.
"anthropic/claude-3.7-sonnet:thinking",
Expand Down
2 changes: 2 additions & 0 deletions src/api/providers/fetchers/__tests__/openrouter.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,8 @@ describe("OpenRouter API", () => {
"google/gemini-2.5-flash-lite-preview-06-17",
"google/gemini-2.5-pro",
"anthropic/claude-opus-4.1", // Not yet available in OpenRouter API
"z-ai/glm-4.5-air", // Not yet in test fixture
"z-ai/glm-4.5-air:free", // Not yet in test fixture
Copy link
Contributor Author

@roomote roomote bot Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: Suggest turning this into a TODO with a removal condition, e.g., TODO: Remove once OpenRouter fixtures include GLM 4.5 Air models so we can assert them directly. This makes the follow-up action explicit.

])

const expectedReasoningBudgetModels = Array.from(OPEN_ROUTER_REASONING_BUDGET_MODELS)
Expand Down
Loading