Debug extension bridge url #8347
Closed
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| if (!instance) { | ||
| try { | ||
| console.log(`[BridgeOrchestrator#connectOrDisconnect] Connecting...`) | ||
| console.log(`[BridgeOrchestrator#connectOrDisconnect] Connecting to ${options.socketBridgeUrl}...`) |
Contributor
There was a problem hiding this comment.
P1: Logging the full socketBridgeUrl can leak sensitive information (query params like token/key, or basic-auth). Also handle undefined gracefully. Suggest redacting and adding a fallback.
Suggested change
| console.log(`[BridgeOrchestrator#connectOrDisconnect] Connecting to ${options.socketBridgeUrl}...`) | |
| console.log(`[BridgeOrchestrator#connectOrDisconnect] Connecting to ${(() => { try { const u = new URL(options.socketBridgeUrl ?? ''); u.username = ''; u.password = ''; return u.origin + u.pathname + (u.search ? '?…redacted…' : '') + u.hash; } catch { return options.socketBridgeUrl ?? '(unknown)'; } })()}...`) |
| if (!instance) { | ||
| try { | ||
| console.log(`[BridgeOrchestrator#connectOrDisconnect] Connecting...`) | ||
| console.log(`[BridgeOrchestrator#connectOrDisconnect] Connecting to ${options.socketBridgeUrl}...`) |
Contributor
There was a problem hiding this comment.
P3: The log tag uses "connectOrDisconnect" but this is inside connect(). Consider harmonizing the tag to reduce confusion (follow-up change OK).
hannesrudolph
added
the
Issue/PR - Triage
Member
|
Closing as stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Update log message in
BridgeOrchestratorto includesocketBridgeUrlfor better debugging context.connect()method ofBridgeOrchestratorto includesocketBridgeUrlfor better debugging context.This description was created by
for a421812. You can customize this summary. It will automatically update as commits are pushed.