Skip to content

Debug extension bridge url #8347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Debug extension bridge url #8347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cloud/src/bridge/BridgeOrchestrator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export class BridgeOrchestrator {

if (!instance) {
try {
console.log(`[BridgeOrchestrator#connectOrDisconnect] Connecting...`)
console.log(`[BridgeOrchestrator#connectOrDisconnect] Connecting to ${options.socketBridgeUrl}...`)
Copy link
Contributor

@roomote roomote bot Sep 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Logging the full socketBridgeUrl can leak sensitive information (query params like token/key, or basic-auth). Also handle undefined gracefully. Suggest redacting and adding a fallback.

Suggested change
console.log(`[BridgeOrchestrator#connectOrDisconnect] Connecting to ${options.socketBridgeUrl}...`)
console.log(`[BridgeOrchestrator#connectOrDisconnect] Connecting to ${(() => { try { const u = new URL(options.socketBridgeUrl ?? ''); u.username = ''; u.password = ''; return u.origin + u.pathname + (u.search ? '?…redacted…' : '') + u.hash; } catch { return options.socketBridgeUrl ?? '(unknown)'; } })()}...`)

Copy link
Contributor

@roomote roomote bot Sep 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: The log tag uses "connectOrDisconnect" but this is inside connect(). Consider harmonizing the tag to reduce confusion (follow-up change OK).

// Populate telemetry properties before registering the instance.
await options.provider.getTelemetryProperties()

Expand Down
Loading