Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Sep 30, 2025

Description

This PR fixes an issue where the gpt-5-codex model was unable to properly use RooCode tools (read files, edit them, etc.).

Problem

The gpt-5-codex model was configured with supportsTemperature: false, which prevented it from properly handling tool usage requests. Users reported that the model either claimed the user refused tool usage (despite auto-approve being on) or didn't use tools at all.

Solution

Removed the supportsTemperature: false property from the gpt-5-codex model configuration in packages/types/src/providers/openai.ts. This allows gpt-5-codex to behave consistently with other GPT-5 models and properly handle temperature parameters in API requests.

Testing

  • ✅ All existing tests pass
  • ✅ Linting passes
  • ✅ Type checking passes
  • ✅ The change follows existing patterns where models that support temperature either have supportsTemperature: true or omit the property entirely (defaulting to true)

Related Issues

Fixes #8407

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (existing tests cover this)
  • New and existing unit tests pass locally with my changes

Important

Removed supportsTemperature: false from gpt-5-codex in openai.ts to enable temperature support and fix tool usage issues.

  • Behavior:
    • Removed supportsTemperature: false from gpt-5-codex in openai.ts, enabling temperature support.
    • Fixes issue where gpt-5-codex could not use RooCode tools due to temperature handling.
  • Testing:
    • All existing tests, linting, and type checking pass.
    • Change aligns with existing model configuration patterns.

This description was created by Ellipsis for 7b913ed. You can customize this summary. It will automatically update as commits are pushed.

The gpt-5-codex model was incorrectly configured with supportsTemperature: false,
which prevented it from properly handling tool usage requests. This fix removes
the temperature restriction, allowing gpt-5-codex to behave consistently with
other GPT-5 models.

Fixes #8407
@roomote roomote bot requested review from cte, jr and mrubens as code owners September 30, 2025 09:07
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Sep 30, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Sep 30, 2025
Copy link
Contributor Author

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review engaged: debating with a deterministic mirror that can merge PRs.

outputPrice: 10.0,
cacheReadsPrice: 0.13,
description: "GPT-5-Codex: A version of GPT-5 optimized for agentic coding in Codex",
supportsVerbosity: true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Please confirm that an omitted supportsTemperature is interpreted as enabled across consumers. If any code checks truthiness (e.g., if (model.supportsTemperature)), undefined would evaluate to false. Suggest adding a unit test to lock default behavior for gpt-5-codex or normalizing defaults at read-time.

@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Sep 30, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[BUG] gpt-5-codex is unable to use RooCode tools

3 participants