fix: support Magistral [THINK]...[/THINK] reasoning tags #8523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created new SquareBracketMatcher class to handle square bracket syntax - Updated native-ollama provider to detect Magistral models and use appropriate matcher - Added comprehensive tests for square bracket matching functionality - Maintains backward compatibility with existing XML-style <think> tags Fixes #8522
dosubot
bot
added
size:L
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| constructor( | ||
| readonly tagName: string, | ||
| readonly transform?: (chunks: SquareBracketMatcherResult) => Result, | ||
| readonly position = 0, |
Contributor
There was a problem hiding this comment.
The constructor accepts a 'position' parameter which is never used. Consider removing it or adding a comment to document its intended purpose.
Suggested change
| readonly position = 0, |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| } | ||
|
|
||
| private processComplete() { | ||
| const openTag = `[${this.tagName}]` |
Contributor
Author
There was a problem hiding this comment.
[P1] Matching is case-sensitive. If a Magistral variant emits [think]...[/think], this matcher won’t detect it. Consider normalizing both buffer and tag to a common case during search (for example, use lowercased copies for index lookups while slicing from the original string), or add an optional caseInsensitive flag.
| constructor( | ||
| readonly tagName: string, | ||
| readonly transform?: (chunks: SquareBracketMatcherResult) => Result, | ||
| readonly position = 0, |
Contributor
Author
There was a problem hiding this comment.
[P3] Unused constructor parameter position increases noise and suggests capabilities that aren’t implemented. Remove it or implement position-aware matching.
hannesrudolph
added
the
Issue/PR - Triage
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the issue where Magistral model's reasoning tags using square bracket syntax
[THINK]...[/THINK]were not being properly recognized by Roo Code when using Ollama.Problem
Magistral models use a different syntax for reasoning blocks compared to other models:
<think>...</think>(XML-style)[THINK]...[/THINK](square bracket style)The existing XmlMatcher only handled XML-style tags, causing Magistral's reasoning content to be displayed as regular text.
Solution
SquareBracketMatcherclass that handles square bracket syntaxChanges
src/utils/square-bracket-matcher.ts- Handles[TAG]...[/TAG]syntaxsrc/api/providers/native-ollama.ts- Conditionally uses SquareBracketMatcher for Magistral modelssrc/utils/__tests__/square-bracket-matcher.spec.ts- 12 test cases covering all edge casesTesting
Screenshots
As shown in the issue, Magistral's reasoning tags are now properly recognized and hidden from the output.
Fixes #8522
Important
Adds
SquareBracketMatcherfor[THINK]...[/THINK]tags in Magistral models and updatesNativeOllamaHandlerto use it.SquareBracketMatcherto handle[THINK]...[/THINK]tags insquare-bracket-matcher.ts.NativeOllamaHandlerinnative-ollama.tsto useSquareBracketMatcherfor Magistral models.square-bracket-matcher.spec.tswith 12 test cases forSquareBracketMatchercovering edge cases.XmlMatcherfunctionality.This description was created by
for 6de1c6e. You can customize this summary. It will automatically update as commits are pushed.