fix: ensure checkpoint restore popover works when portal container is not immediately available #8564
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to address Issue #8563 where users reported that clicking on checkpoints does nothing. The issue was caused by the portal container element not being available when the CheckpointMenu component tried to render the popover.
Problem
Solution
Enhanced useRooPortal hook:
useMountwithuseEffectfor better lifecycle managementFixed CheckpointMenu component:
undefinedwhen portal container isnullTesting
Related Issues
Fixes #8563
Feedback and guidance are welcome!
Important
Fixes checkpoint restore popover issue by enhancing
useRooPortalwithMutationObserverand handling null containers inCheckpointMenu.CheckpointMenunow usesportalContainer || undefinedto handle null containers.useRooPortalinuseRooPortal.tsnow usesuseEffectinstead ofuseMount.MutationObserverto detect dynamic addition of portal element.CheckpointSaved.spec.tsx.useRooPortal(e.g.,ModeSelector,ApiConfigSelector) remain unaffected.This description was created by
for a42a50e. You can customize this summary. It will automatically update as commits are pushed.