Skip to content

Conversation

Thibault00
Copy link

@Thibault00 Thibault00 commented Oct 17, 2025

Fixing requesty oauth flow


Important

Fixes Requesty OAuth flow by creating a new profile with a fixed name and default model ID in ClineProvider.ts.

  • Behavior:
    • In ClineProvider.ts, handleRequestyCallback() now creates a new Requesty profile with a fixed name "Requesty" and default model ID requestyDefaultModelId.
    • Removes usage of apiConfiguration and currentApiConfigName from getState() in handleRequestyCallback().
  • Misc:
    • Simplifies the Requesty OAuth flow by directly setting the profile name and model ID.

This description was created by Ellipsis for a97ecd9. You can customize this summary. It will automatically update as commits are pushed.

@Thibault00 Thibault00 requested review from cte, jr and mrubens as code owners October 17, 2025 10:53
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 17, 2025
Copy link

roomote bot commented Oct 17, 2025

Review Summary

Issues Found: 1

Issues to Address:

  • Preserve base provider settings when creating Requesty profile (diffEnabled, fuzzyMatchThreshold, rateLimitSeconds, etc.)

Review completed by Roo Code PR Review

@dosubot dosubot bot added the bug Something isn't working label Oct 17, 2025
Comment on lines 1460 to 1464
const newConfiguration: ProviderSettings = {
...apiConfiguration,
apiProvider: "requesty",
requestyApiKey: code,
requestyModelId: apiConfiguration?.requestyModelId || requestyDefaultModelId,
requestyModelId: requestyDefaultModelId,
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation creates a Requesty profile without preserving base provider settings (like diffEnabled, fuzzyMatchThreshold, rateLimitSeconds, consecutiveMistakeLimit, etc.) that users may have customized. Unlike the OpenRouter (line 1414) and Glama (line 1447) handlers which spread apiConfiguration to preserve these settings, this creates a minimal configuration with only Requesty-specific fields. Consider preserving user preferences: { ...apiConfiguration, apiProvider: "requesty", requestyApiKey: code, requestyModelId: requestyDefaultModelId }

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Thibault00 what do you think of this? Would it cause any issues to preserve the apiConfiguration like the others?

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

3 participants