Skip to content

fix: create new Requesty profile during OAuth #8699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: create new Requesty profile during OAuth #8699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/core/webview/ClineProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1457,16 +1457,13 @@ export class ClineProvider
// Requesty

async handleRequestyCallback(code: string) {
let { apiConfiguration, currentApiConfigName = "default" } = await this.getState()

const newConfiguration: ProviderSettings = {
...apiConfiguration,
apiProvider: "requesty",
requestyApiKey: code,
requestyModelId: apiConfiguration?.requestyModelId || requestyDefaultModelId,
requestyModelId: requestyDefaultModelId,
}
Comment on lines 1460 to 1464
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation creates a Requesty profile without preserving base provider settings (like diffEnabled, fuzzyMatchThreshold, rateLimitSeconds, consecutiveMistakeLimit, etc.) that users may have customized. Unlike the OpenRouter (line 1414) and Glama (line 1447) handlers which spread apiConfiguration to preserve these settings, this creates a minimal configuration with only Requesty-specific fields. Consider preserving user preferences: { ...apiConfiguration, apiProvider: "requesty", requestyApiKey: code, requestyModelId: requestyDefaultModelId }

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Thibault00 what do you think of this? Would it cause any issues to preserve the apiConfiguration like the others?


await this.upsertProviderProfile(currentApiConfigName, newConfiguration)
await this.upsertProviderProfile("Requesty", newConfiguration)
}

// Task history
Expand Down