feat: add generate commit message feature for staged changes #8862

roomote · 2025-10-27T16:14:03Z

Summary

This PR implements Issue #8861 by adding a feature to generate AI-powered commit messages for staged changes in VSCode.

Changes

✨ Added a new generateCommitMessage command that appears as a sparkle icon button in the SCM title bar
🔧 Implemented git utility functions to retrieve staged diff and files
🤖 Created command handler that uses the Roo Code AI to generate conventional commit messages
🌐 Added localization support for the new command
📝 Follows conventional commit format (feat:, fix:, docs:, etc.)

How it works

Users stage their changes using git add
Click the sparkle icon (✨) in the Source Control view title bar
The extension analyzes the staged changes and generates an appropriate commit message
The generated message is automatically inserted into the commit message input box

Testing

✅ TypeScript compilation passes
✅ ESLint checks pass
✅ All existing tests pass
✅ Code review confidence: 92% (High)

Screenshots

The sparkle icon appears in the SCM title bar when git is the active SCM provider and provides one-click commit message generation.

Closes #8861

Important

Adds AI-powered commit message generation for staged changes in VSCode with a new generateCommitMessage command.

Feature:
- Adds generateCommitMessage command in registerCommands.ts for AI-powered commit message generation.
- Integrates with Roo Code AI to generate messages following conventional commit format.
- Displays a sparkle icon in the SCM title bar for easy access.
Utilities:
- Implements getStagedDiff and getStagedFiles in git.ts to retrieve staged changes.
Localization:
- Adds localization support for the new command in package.nls.json.
Configuration:
- Updates package.json to include the new command and its icon.

^{This description was created by}^{for 4d29f89. You can customize this summary. It will automatically update as commits are pushed.}

- Add generateCommitMessage command to package.json with SCM menu integration - Implement git utility functions to get staged diff and files - Create command handler that uses AI to generate conventional commit messages - Add localization support for the new command - Add sparkle icon to the SCM title bar for easy access This feature allows users to generate AI-powered commit messages based on their staged changes, following conventional commit format.

roomote · 2025-10-27T16:14:28Z

Code Review Summary

I've reviewed the PR and identified several architectural issues that need to be addressed:

Issues Found

Improper task creation for simple API call - The implementation creates a full task instance for generating a commit message, which causes resource leaks and is inappropriate. The task system is designed for interactive, multi-step operations, not one-off API calls. Consider using the API handler directly instead.
Fragile polling mechanism - The polling approach (checking messages every 100ms for 30 seconds) is prone to race conditions and relies on internal task message format that could change. There's no proper error handling if the task fails or produces unexpected output.
Task cleanup missing - The created task is never properly disposed, only removed from the stack. This leaks resources (event listeners, file watchers), pollutes task history, and creates unnecessary UI entries.

Recommendation

Refactor to use the API handler directly with buildApiHandler(apiConfiguration).createMessage() instead of creating a task instance. This will be more efficient, cleaner, and avoid all the resource management issues.

Follow Along on Roo Code Cloud

ellipsis-dev · 2025-10-27T16:16:26Z

src/activate/registerCommands.ts

+	generateCommitMessage: async () => {
+		const cwd = getWorkspacePath()
+		if (!cwd) {
+			vscode.window.showErrorMessage("No workspace folder open")


User‐facing strings (e.g. error and info messages) are hard‐coded. Consider wrapping these messages with the i18n function t() so that they are localizable.

Suggested change

vscode.window.showErrorMessage("No workspace folder open")

vscode.window.showErrorMessage(t("No workspace folder open"))

^{This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.}

roomote · 2025-10-27T16:17:38Z

src/activate/registerCommands.ts

+Please provide ONLY the commit message, without any additional explanation or formatting. The message should be on a single line unless a body is needed for complex changes.`
+
+					// Create a task and wait for the response
+					const task = await visibleProvider.createTask(prompt)


Creating a full task instance for generating a commit message is inappropriate and causes resource leaks. The task system is designed for interactive, multi-step user operations, not one-off API calls. This approach: (1) adds the task to the provider's task stack without proper cleanup, (2) creates unnecessary state and event listeners, (3) persists the task to disk unnecessarily. Consider using the API handler directly with buildApiHandler(apiConfiguration).createMessage() instead of createTask().

roomote · 2025-10-27T16:17:58Z

src/activate/registerCommands.ts

+					await new Promise<void>((resolve) => {
+						let checkCount = 0
+						const maxChecks = 300 // 30 seconds with 100ms intervals
+
+						const checkInterval = setInterval(() => {
+							checkCount++
+							const messages = task.clineMessages
+
+							// Look for a message with type "say" and say "completion_result"
+							const completionMessage = messages.find(
+								(msg) => msg.type === "say" && msg.say === "completion_result",
+							)
+
+							if (completionMessage || checkCount >= maxChecks) {
+								clearInterval(checkInterval)


This polling mechanism is fragile and prone to race conditions. It checks task messages every 100ms for up to 30 seconds, but there's no guarantee the message structure will be as expected when using createTask(). The check relies on internal task message format (type === 'say' && say === 'completion_result') which could change or be missing. If the task fails, times out, or produces unexpected message format, this will silently fail after 30 seconds without proper error handling.

roomote · 2025-10-27T16:18:19Z

src/activate/registerCommands.ts

+								}
+
+								// Clear the task
+								visibleProvider.clearTask()


The task created for commit message generation is never properly cleaned up. After extracting the commit message, visibleProvider.clearTask() is called, but this only removes the task from the stack without proper disposal. The task will remain in task history, pollute the UI with unnecessary entries, and leak resources (event listeners, file watchers, etc.). Consider calling task.dispose() explicitly or better yet, avoid creating a task entirely for this use case.

roomote bot requested review from cte, jr and mrubens as code owners October 27, 2025 16:14

github-project-automation bot added this to Roo Code Roadmap and Roo Code Roadmap Oct 27, 2025

github-project-automation bot moved this to New in Roo Code Roadmap Oct 27, 2025

github-project-automation bot moved this to Triage in Roo Code Roadmap Oct 27, 2025

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Oct 27, 2025

hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Oct 27, 2025

ellipsis-dev bot reviewed Oct 27, 2025

View reviewed changes

roomote bot commented Oct 27, 2025

View reviewed changes

roomote bot mentioned this pull request Oct 27, 2025

[ENHANCEMENT] Generate Commit messages #8861

Closed

2 tasks

daniel-lxs closed this Oct 29, 2025

github-project-automation bot moved this from New to Done in Roo Code Roadmap Oct 29, 2025

github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Oct 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add generate commit message feature for staged changes #8862

feat: add generate commit message feature for staged changes #8862

Uh oh!

roomote bot commented Oct 27, 2025 •

edited by ellipsis-dev bot

Loading

Uh oh!

roomote bot commented Oct 27, 2025 •

edited

Loading

Uh oh!

ellipsis-dev bot Oct 27, 2025

Uh oh!

roomote bot Oct 27, 2025

Uh oh!

roomote bot Oct 27, 2025

Uh oh!

roomote bot Oct 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	vscode.window.showErrorMessage("No workspace folder open")
	vscode.window.showErrorMessage(t("No workspace folder open"))

feat: add generate commit message feature for staged changes #8862

feat: add generate commit message feature for staged changes #8862

Uh oh!

Conversation

roomote bot commented Oct 27, 2025 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

How it works

Testing

Screenshots

Uh oh!

roomote bot commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Summary

Issues Found

Recommendation

Uh oh!

ellipsis-dev bot Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

roomote bot Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

roomote bot Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

roomote bot Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

roomote bot commented Oct 27, 2025 •

edited by ellipsis-dev bot

Loading

roomote bot commented Oct 27, 2025 •

edited

Loading