feat(vscode): disable terminal shell integration by default to reduce onboarding errors

[roomote]

Summary:

• Default-disable VS Code Terminal Shell Integration to avoid first-run terminal failures.

Change:

• Added contributes.configurationDefaults in extension manifest to set:
  • terminal.integrated.shellIntegration.enabled = false
  • terminal.integrated.shellIntegration.suggestEnabled = false

Key file:

• src/package.json

Rationale:

• Many new users immediately hit a terminal error when shell integration fails to initialize. Disabling by default avoids noisy failures during onboarding while still allowing users to re-enable if desired.

How to re-enable (user settings):
{
"terminal.integrated.shellIntegration.enabled": true,
"terminal.integrated.shellIntegration.suggestEnabled": true
}

Compatibility:

• Verified setting names are valid for engines.vscode >= ^1.84.0.

Tests:

• Ran unit/integration tests (vitest); all passed (3,936 passed, 48 skipped).

Security/Impact:

• No runtime code changes. Pure configuration default; low risk.

---

Important

Default-disable terminal shell integration in VS Code to prevent onboarding errors, configurable in src/package.json.

• Behavior:
  • Default-disable terminal shell integration in VS Code to prevent first-run errors.
  • Added configurationDefaults in src/package.json to set terminal.integrated.shellIntegration.enabled and terminal.integrated.shellIntegration.suggestEnabled to false.
• Rationale:
  • Prevents terminal errors for new users during onboarding.
  • Users can re-enable shell integration in settings if desired.
• Compatibility:
  • Compatible with VS Code version 1.84.0 and above.
• Testing:
  • All unit and integration tests passed (3,936 passed, 48 skipped).

^{This description was created by for 1cfaaa1. You can customize this summary. It will automatically update as commits are pushed.}

[roomote]

Review Summary

I've identified a critical issue with this PR that needs to be addressed:

• Disabling shell integration by default breaks core terminal functionality (lines 337-339 in src/package.json)

The extension's command execution system is designed around shell integration being available. Without it, commands execute without proper output capture or status tracking, severely degrading functionality for all users.

Follow Along on Roo Code Cloud

[roomote]

Disabling shell integration by default breaks core terminal functionality. The extension's command execution system (TerminalProcess.ts, Terminal.ts, executeCommandTool.ts) is designed around shell integration being available. Without it, commands execute blindly without output capture or status tracking, resulting in messages like "shell integration is not available, so terminal output and command execution status is unknown". The codebase has fallback handling for when shell integration fails to initialize, but it's designed as an error path, not the default behavior. This change would severely degrade the user experience for all users to potentially fix onboarding issues for some users. Consider alternative solutions like better error messaging, graceful degradation, or targeted fixes for specific shell environments instead of disabling a critical feature globally.

[daniel-lxs]

I think this won't work, the property configurationDefaults doesn't seem to be parsed anywhere.