Skip to content

feat(vscode): disable terminal shell integration by default to reduce onboarding errors #8898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

feat(vscode): disable terminal shell integration by default to reduce onboarding errors #8898

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2043ec
feat(vscode): disable integrated terminal shell integration by defaul…
roomote Oct 29, 2025
1cfaaa1
fix(vscode): only default-disable terminal shell integration; do not …
roomote Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,10 @@
"label": "%views.terminalMenu.label%"
}
],
"configurationDefaults": {
"terminal.integrated.shellIntegration.enabled": false,
"terminal.integrated.shellIntegration.suggestEnabled": false
},
Comment on lines 337 to 339
Copy link
Author

@roomote roomote bot Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling shell integration by default breaks core terminal functionality. The extension's command execution system (TerminalProcess.ts, Terminal.ts, executeCommandTool.ts) is designed around shell integration being available. Without it, commands execute blindly without output capture or status tracking, resulting in messages like "shell integration is not available, so terminal output and command execution status is unknown". The codebase has fallback handling for when shell integration fails to initialize, but it's designed as an error path, not the default behavior. This change would severely degrade the user experience for all users to potentially fix onboarding issues for some users. Consider alternative solutions like better error messaging, graceful degradation, or targeted fixes for specific shell environments instead of disabling a critical feature globally.

"configuration": {
"title": "%configuration.title%",
"properties": {
Expand Down