Skip to content

Conversation

@roomote
Copy link

@roomote roomote bot commented Oct 29, 2025

This PR removes the non-independent editor tab flow that caused state conflicts. Changes: • Remove commands: popoutButtonClicked, openInNewTab (src/package.json, packages/types/src/vscode.ts) • Strip editor/title menu contributions and TabPanel-specific “when” clauses from package.json • Delete command wiring and tab panel launcher logic in registerCommands.ts (openClineInNewTab, popout handler) • Ensure API always uses sidebar provider (src/extension/api.ts) • Update tests to reflect removals (apps/vscode-e2e/extension.test.ts, packages/build/src/tests/index.test.ts). All vitest suites pass across src, webview-ui, and packages/build.


Important

Remove 'Open in Editor' and 'openInNewTab' functionalities, updating commands, menus, and tests accordingly.

  • Behavior:
    • Remove popoutButtonClicked and openInNewTab commands from package.json and vscode.ts.
    • Remove editor/title menu contributions and TabPanel-specific "when" clauses from package.json.
    • Delete command wiring and tab panel launcher logic in registerCommands.ts.
    • Ensure API always uses sidebar provider in api.ts.
  • Tests:
    • Update tests in extension.test.ts and index.test.ts to reflect command removals.
  • Misc:
    • All vitest suites pass across src, webview-ui, and packages/build.

This description was created by Ellipsis for 941e5ae. You can customize this summary. It will automatically update as commits are pushed.

@roomote roomote bot requested review from cte, jr and mrubens as code owners October 29, 2025 03:34
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. UI/UX UI/UX related or focused labels Oct 29, 2025
@roomote
Copy link
Author

roomote bot commented Oct 29, 2025

Review Complete

I've completed my review of this pull request. No issues were identified.

The PR successfully removes the "Open in Editor" and openInNewTab functionality with all changes properly coordinated across:

  • Type definitions (packages/types/src/vscode.ts)
  • Command registration (src/activate/registerCommands.ts)
  • Package manifest (src/package.json)
  • API layer (src/extension/api.ts)
  • All related tests

All changes are internally consistent and no bugs were introduced.


Follow Along on Roo Code Cloud

Copy link
Author

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Oct 29, 2025
@daniel-lxs daniel-lxs closed this Oct 29, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Oct 29, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:L This PR changes 100-499 lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants